Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package: signature-rm v1.0.2 #772

Merged
merged 10 commits into from
Dec 8, 2023

Conversation

rM-self-serve
Copy link
Contributor

Release Notes v1.0.2
Docs

Remove the signature from the bottom of emails sent from the device. It will also take a backup before the modification, and allow reverting the modification from the backup or by performing the modification in reverse.

I am the author of this software. This should work on all devices+versions.

It will ensure the modification is possible before performing it by checking for the "guilty" string rather than a shasum. It will attempt to revert the modification when uninstalled, if it is applied.


How it works:
In xochitl:

  • change 'Sent from my reMarkable' to '\0ent from my reMarkable'

@Eeems Eeems added the packages Add or improve packages of the repository label Dec 6, 2023
@Eeems Eeems added this to the 2023-W49 Merge Window milestone Dec 6, 2023
Copy link
Member

@Eeems Eeems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as the webinterface-onboot package.

This should be automatically applied with configure(), and ddvk-hacks's configure() should be updated to check for this, remove the signature, and then reapply it after it's done patching. That or this should be marked as conflicts with ddvk-hacks

@rM-self-serve
Copy link
Contributor Author

This can be tested with:
signature-rm is-applied

Reinstall on reenable:
sigrm_reinstall_update

@rM-self-serve
Copy link
Contributor Author

If both #770 and #772 are installed when the device is reenabled, its possible the first binary modification "fills up" (until xochitl is restarted) the root partition so that the second binary modification fails. Thus, make them conflict.

@Eeems
Copy link
Member

Eeems commented Dec 8, 2023

If both #770 and #772 are installed when the device is reenabled, its possible the first binary modification "fills up" (until xochitl is restarted) the root partition so that the second binary modification fails. Thus, make them conflict.

Since this is also a concern for ddvk-hacks, could you open a separate issue to track this. I think we should explore moving xochitl off of the root partition for modifications. Or at the very least move the modified copy of it to /opt instead of running the main one.

Edit: I do think we need to resolve this before 3.x support. And since it's a pre-existing issue with our packages, I don't see a reason it should keep this from being merged.

@Eeems Eeems merged commit 051ca4c into toltec-dev:testing Dec 8, 2023
3 checks passed
Eeems added a commit that referenced this pull request Dec 10, 2023
* Add package: signature-rM v1.0.2

* auto apply/revert; reinstall on reenable

* conflicts=(ddvk-hacks)

* remove error suppression

* #770 and #772 conflict

---------

Co-authored-by: Nathaniel van Diepen <Eeems@users.noreply.github.com>
@rM-self-serve rM-self-serve deleted the package/signature-rm branch December 16, 2023 15:43
Eeems added a commit that referenced this pull request Dec 26, 2023
### New Packages
- `webinterface-onboot` 1.2.2-2 - (#770 #721)
  - Allows the usb web interface to start without the USB cable being connected.
- `webinterface-upload-button` - 1.0.1-1 (#771)
  - Adds an upload button to the usb web interface.
- `signature-rm` - 1.0.2-1 (#772)
  - Removes the `Sent from my reMarkable` signature from emails sent by the device.

### Updated Packages
- `linux-stracciatella` - 5.4.70-3 (#742)
  - Updated to RM1XX_5.4.70_v1.3.4 tag from upstream kernel.
  - Added wireguard module.
- `wireguard` - 1.0.20210219-4 (#743 #784)
  - Removed wireguard-tools and wg-quick from wireguard package. These packages are provided by entware already.
- `display` and `rm2fb-client` - 1:0.0.32-2 (#758 #721)
  - Add support for OS 3.3.2.1666
- `rmfm` - 1.5.1-1 (#766)
  - Fix issue where listing a directory with an invalid symlink would crash the application.
- `neofetch` - 1.1.0-1 (#769)
- `webinterface-wifi` - 2.0.0-2 (#768 #721)
- `micro` - 2.0.13-1 (#738)
- `koreader` - 2023.10-2 (#749 #721)
- `ddvk-hacks` - 39.01-2 (#720 #778)
  - Fix issue where `ddvk-hacks` wouldn't be reapplied when using `toltecctl reenable`.
- `draft` - 0.2.0-22 (#721)
- `erode`, `fret`, `oxide`, `rot`, `tarnish`, `decay`, `corrupt`, `anxiety`, `oxide-utils`, `inject_evdev`, and `liboxide` - 2.6-3 (#721)
- `reboot-guard` - 1.0.1-8 (#721)
- `rmfakecloud-proxy` - 0.0.3-4 (#721)
- `genie` - 0.1.6-3 (#721)
- `remux` - 0.2.4-2 (#721)
- `tailscale-systemd` - 0.0.0-2 (#721)
- `toltec-base` - 1.2-3 (#721)
- `xochitl` - 0.0.0-17 (#721)

### Tooling
- New `provides=()` field added for packages.
- Added `unit-exists` and `disable-unit` methods to install-lib

**Note:** This doesn't change what OS version that toltec supports, as full support still requires various packages to be updated, removed, or replaced. Along with proper testing of all packages in the repository, as well as the upgrade process. https://github.com/toltec-dev/toltec/milestone/7 contains the current list of issues and pull requests required for 3.x support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages Add or improve packages of the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants