Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webinterface-wifi to v2.0.0 #768

Merged
merged 7 commits into from
Dec 8, 2023

Conversation

rM-self-serve
Copy link
Contributor

@rM-self-serve rM-self-serve commented Dec 6, 2023

Release Notes v2.0.0
Docs

Quite a bit of new functionality.

Should work on all devices+versions.

For anyone testing this, there are test ssl certs in the repository. It is necessary the wifi is connected and the web interface is accessible at 10.11.99.1. The following tests should suffice.


$ webint-wifi net-info
# ensure the wifi ssid is correct 

$ systemctl start webinterface-wifi
$ webint-wifi create-login
# enter a username/password 
$ webint-wifi edit
# change [undefined_networks].login_enforced to true
$ webint-wifi reload

Then navigate to the wifi ip address in a browser, enter the credentials, and download a file.

@Eeems Eeems added the packages Add or improve packages of the repository label Dec 6, 2023
@Eeems Eeems added this to the 2023-W49 Merge Window milestone Dec 6, 2023
Copy link
Member

@Eeems Eeems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon testing, trying to enable the service doesn't work as it's trying to run /opt/bin/webinterface-wifi --run 80 which is no longer valid.

It may also be worth adding some more helpful output to configure() to point the user in the right direction for configuring it?

@rM-self-serve
Copy link
Contributor Author

Sorry for that oversight, the correct service file should now be installed.

I mentioned where to find usage and docs locally and remotely.

Thanks for testing! I was not aware of the release window so my apologies for cutting it so close.

@Eeems Eeems self-requested a review December 7, 2023 01:39
@Eeems
Copy link
Member

Eeems commented Dec 7, 2023

Sorry for that oversight, the correct service file should now be installed.

I mentioned where to find usage and docs locally and remotely.

No worries, this is why we test 😛

Thanks for testing! I was not aware of the release window so my apologies for cutting it so close.

No worries about the release window. I just picked the earlier one as I don't have to rely on another maintainer to test this.

@rM-self-serve
Copy link
Contributor Author

Sounds good to me!

@Eeems Eeems self-requested a review December 7, 2023 18:07
@Eeems
Copy link
Member

Eeems commented Dec 7, 2023

Okay, testing this, and I realized it doesn't automatically restart the service if it's already enabled and running. Since this isn't a launcher which could have various applications running in an unsaved state, it should be safe to restart the service.

if is-active webinterface-wifi.service; then
    systemctl restart webinterface-wifi
fi

@Eeems Eeems merged commit 54d1e65 into toltec-dev:testing Dec 8, 2023
3 checks passed
Eeems added a commit that referenced this pull request Dec 10, 2023
* Update webinterface-wifi to v2.0.0

* reload daemon if running on upgrade

---------

Co-authored-by: Nathaniel van Diepen <Eeems@users.noreply.github.com>
@rM-self-serve rM-self-serve deleted the package/webinterface-wifi branch December 16, 2023 15:43
Eeems added a commit that referenced this pull request Dec 26, 2023
### New Packages
- `webinterface-onboot` 1.2.2-2 - (#770 #721)
  - Allows the usb web interface to start without the USB cable being connected.
- `webinterface-upload-button` - 1.0.1-1 (#771)
  - Adds an upload button to the usb web interface.
- `signature-rm` - 1.0.2-1 (#772)
  - Removes the `Sent from my reMarkable` signature from emails sent by the device.

### Updated Packages
- `linux-stracciatella` - 5.4.70-3 (#742)
  - Updated to RM1XX_5.4.70_v1.3.4 tag from upstream kernel.
  - Added wireguard module.
- `wireguard` - 1.0.20210219-4 (#743 #784)
  - Removed wireguard-tools and wg-quick from wireguard package. These packages are provided by entware already.
- `display` and `rm2fb-client` - 1:0.0.32-2 (#758 #721)
  - Add support for OS 3.3.2.1666
- `rmfm` - 1.5.1-1 (#766)
  - Fix issue where listing a directory with an invalid symlink would crash the application.
- `neofetch` - 1.1.0-1 (#769)
- `webinterface-wifi` - 2.0.0-2 (#768 #721)
- `micro` - 2.0.13-1 (#738)
- `koreader` - 2023.10-2 (#749 #721)
- `ddvk-hacks` - 39.01-2 (#720 #778)
  - Fix issue where `ddvk-hacks` wouldn't be reapplied when using `toltecctl reenable`.
- `draft` - 0.2.0-22 (#721)
- `erode`, `fret`, `oxide`, `rot`, `tarnish`, `decay`, `corrupt`, `anxiety`, `oxide-utils`, `inject_evdev`, and `liboxide` - 2.6-3 (#721)
- `reboot-guard` - 1.0.1-8 (#721)
- `rmfakecloud-proxy` - 0.0.3-4 (#721)
- `genie` - 0.1.6-3 (#721)
- `remux` - 0.2.4-2 (#721)
- `tailscale-systemd` - 0.0.0-2 (#721)
- `toltec-base` - 1.2-3 (#721)
- `xochitl` - 0.0.0-17 (#721)

### Tooling
- New `provides=()` field added for packages.
- Added `unit-exists` and `disable-unit` methods to install-lib

**Note:** This doesn't change what OS version that toltec supports, as full support still requires various packages to be updated, removed, or replaced. Along with proper testing of all packages in the repository, as well as the upgrade process. https://github.com/toltec-dev/toltec/milestone/7 contains the current list of issues and pull requests required for 3.x support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages Add or improve packages of the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants