Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VS2019 warnings #42

Closed
tom-seddon opened this issue Jul 3, 2019 · 1 comment
Closed

VS2019 warnings #42

tom-seddon opened this issue Jul 3, 2019 · 1 comment
Labels
admin repo, CI, build, etc.

Comments

@tom-seddon
Copy link
Owner

There's a vast number of analyze warnings...

Should add SAL markup to b2 code to fix them.

Third-party libraries: open question! Check submodules and merge in upstream updates if this is fixed. Disable warnings if active projects haven't fixed it yet. Relacy looks rather un(der)maintained... might need some local patches?
tom-seddon added a commit that referenced this issue Jul 4, 2019
@tom-seddon
Fix VS2019 warnings that were easy fixes or obviously problems.
349ed99 
There's still tons left, but since it builds fairly cleanly on
VS2015/VS2017/Xcode/gcc, I'm figuring this can be an ongoing task...

#42
@tom-seddon tom-seddon added the admin repo, CI, build, etc. label Jul 5, 2019
@tom-seddon
Copy link
Owner Author

Warnings are now OK.

Not going to bother with the analyze warnings.

  1. No markup on std::unique_lock - there's probably more of this to be found...
  2. Seems to be very hard to annotate mutex wrappers
  3. Spurious warnings about std::unique_ptr::operator* result pointing to memory on the stack

Should probably revisit this occasionally though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
admin repo, CI, build, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tom-seddon