Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a vec of entities instead of children #115

Closed
tomara-x opened this issue Mar 13, 2024 · 9 comments · Fixed by #132
Closed

use a vec of entities instead of children #115

tomara-x opened this issue Mar 13, 2024 · 9 comments · Fixed by #132
Labels

Comments

@tomara-x
Copy link
Owner

tomara-x commented Mar 13, 2024

  • avoids some of the stuff we had to do in 85faab3 #114 (we can just remove the entity)
  • manual transform propagation allows for custom behavior (fixing transform propagation issues #111)
  • make_children_change won't be needed (move them manually)
@tomara-x tomara-x added the yeet label Mar 13, 2024
@tomara-x
Copy link
Owner Author

tomara-x commented Mar 13, 2024

can we use children for things like highlights and info texts now? (after you're done)

@tomara-x
Copy link
Owner Author

tomara-x commented Mar 13, 2024

  • this would mean you'd have to rewrite delete (when deleting a hole make sure to remove it from its parent's vec, and when deleting a parent delete holes first)...
    doubt..

  • need a parent field for each wh and bh [why?! pls! always write why! can't we just do the double get?]

@tomara-x
Copy link
Owner Author

nope, nope

@tomara-x tomara-x closed this as not planned Won't fix, can't repro, duplicate, stale Mar 15, 2024
@tomara-x tomara-x mentioned this issue Mar 16, 2024
@tomara-x
Copy link
Owner Author

hiding is no more use here

@tomara-x tomara-x reopened this Mar 17, 2024
@tomara-x
Copy link
Owner Author

tomara-x commented Mar 17, 2024

for now at least, don't propagate anything, will have a command to select children.
and maybe that :add command? for delta kind of movement

@tomara-x
Copy link
Owner Author

tomara-x commented Mar 17, 2024

find all global transforms after you're done, and clean all of that done

@tomara-x
Copy link
Owner Author

tomara-x commented Mar 17, 2024

cleanup in aisle move_selected done

@tomara-x
Copy link
Owner Author

tomara-x commented Mar 17, 2024

find any use of Parent done

@tomara-x
Copy link
Owner Author

tomara-x commented Mar 17, 2024

they're no longer parented, so they're all there in the sceneinstance.. post needs a rewrite done

@tomara-x tomara-x linked a pull request Mar 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant