Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create unit tests for todos effects #265

Closed
tomastrajan opened this issue Jun 26, 2018 · 4 comments
Closed

Create unit tests for todos effects #265

tomastrajan opened this issue Jun 26, 2018 · 4 comments

Comments

@tomastrajan
Copy link
Owner

tomastrajan commented Jun 26, 2018

Create tests for todos.effects.ts in todos.effects.spec.ts file either by following official ngrx testing guide or feel free to suggest any improvements.

Try to keep tests as independent as possible (eg minimize importing of various modules in setting up tests)

Feel free to check out Contributors Guide for useful tips and hints that help you get started.

@terrystrachan
Copy link
Contributor

I'd like to take this one as my first ever contribution

@timdeschryver
Copy link
Collaborator

Awesome! Feel free to reach out if you need any help.

@terrystrachan
Copy link
Contributor

thanks @timdeschryver
Created a test similar to settings.effects.spec.ts for todos.effects.ts
Tests pass
CI passes
Going to create a pull request for review

tomastrajan added a commit that referenced this issue Sep 18, 2018
test(todos): create unit tests for todos effects test #265
@tomastrajan
Copy link
Owner Author

Ah, the commit message referenced the issue but didn't contain keyword like closes or fixes so I have to close issue manually, anyway @terrystrachan thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants