You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Create tests for todos.effects.ts in todos.effects.spec.ts file either by following official ngrx testing guide or feel free to suggest any improvements.
Try to keep tests as independent as possible (eg minimize importing of various modules in setting up tests)
Feel free to check out Contributors Guide for useful tips and hints that help you get started.
The text was updated successfully, but these errors were encountered:
thanks @timdeschryver
Created a test similar to settings.effects.spec.ts for todos.effects.ts
Tests pass
CI passes
Going to create a pull request for review
Ah, the commit message referenced the issue but didn't contain keyword like closes or fixes so I have to close issue manually, anyway @terrystrachan thanks again!
Create tests for
todos.effects.ts
intodos.effects.spec.ts
file either by following official ngrx testing guide or feel free to suggest any improvements.Try to keep tests as independent as possible (eg minimize importing of various modules in setting up tests)
Feel free to check out Contributors Guide for useful tips and hints that help you get started.
The text was updated successfully, but these errors were encountered: