Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mocha doesn't terminate #256

Closed
damo-da opened this issue Aug 6, 2018 · 3 comments
Closed

Mocha doesn't terminate #256

damo-da opened this issue Aug 6, 2018 · 3 comments

Comments

@damo-da
Copy link

damo-da commented Aug 6, 2018

Mocha doesn't terminate during integration test run using ./scripts/test/int.sh, and suspect this because the mocha developers decided to change the mocha termination behavior starting v4.0.0. This answer explains it. Should we add the --exit flags to int.sh and unit.sh? (Please do note that unit.sh is terminating however)

Configuration:

mocha (global): 5.2.0
node: v10.7.0
@tomatau
Copy link
Owner

tomatau commented Aug 7, 2018

Oh hey! So sorry I'm super busy at the moment, hoping to go all out on this boilerplate within the next month once I've caught up in other areas and then will get on this error! I'm surprised you're seeing this as the latest master worked fine for me and in CI, it might be a node 10 issue. I've put off upping to node 10 until it goes LTS in October.

@damo-da
Copy link
Author

damo-da commented Aug 7, 2018

Sure, sounds good. I am using the --exit flag for now so that mocha works like a charm!

@tomatau
Copy link
Owner

tomatau commented Sep 2, 2018

Hi, I can't reproduce this in node 10

@tomatau tomatau closed this as completed Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomatau @damo-da