New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update react-helmet #319

Closed

tomatau opened this issue May 24, 2019 · 1 comment · Fixed by #394

Owner

tomatau commented May 24, 2019

nfl/react-helmet#260 (comment)

Owner Author

tomatau commented Aug 13, 2019

React-helmet now uses side-effect that in turn uses componentWillMount. This is causing errors in dev and test:

Warning: componentWillMount has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

* Move code from componentWillMount to componentDidMount (preferred in most cases) or the constructor.

Please update the following components: SideEffect(NullComponent)

nfl/react-helmet#465

tomatau mentioned this issue

swaps react-helmet for react-helmet-async to remove deprecation warnings #394

Merged

tomatau closed this as completed in #394

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment