Recordlayer helpers #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since Python 3 does put .pyc files into different directories than Python 2, we need to clean both locations
Because the RecordLayer method sendMessage actually sends a record as-is without any fragmentation or length checks (with the exception of the implicit length limit enforced by two-byte length field), a better name for it is "sendRecord" rename allowed since the API was not part of a stable release yet
Because the RecordLayer method recvMessage actually reads a record and returns it to caller as-is without any defragmentation or message splitting, a better name for it is "recvRecord" rename allowed since the API was not part of a stable release yet
add a wrapper around RecordLayer that makes it easier to handle sending and receiving messages through it, especially aimed at handling handshake messages
tomato42
force-pushed
the
recordlayer-helpers
branch
from
b138550
to
8409475
Compare
tomato42
force-pushed
the
recordlayer-helpers
branch
from
8409475
to
ac7c251
Compare
since MessageSocket doesn't return correct record layer header for the messages it provides, add tests which show those limits
since record layer version may be useful for debugging, do try to provide at least an approximate version information providing length is completely useless as it would be just duplication of len(ret[1])
|
|
|
obsoleted by #21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add few classes that make handling record layer messages easier