Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the ChaCha cipher #34

Merged
merged 4 commits into from
Nov 11, 2015
Merged

Implement the ChaCha cipher #34

merged 4 commits into from
Nov 11, 2015

Conversation

tomato42
Copy link
Member

Fixes #16

@tomato42 tomato42 added this to the v0.6.0 milestone Sep 20, 2015
@landscape-bot
Copy link

Code Health
Repository health increased by 0.45% when pulling 444755b on chacha20 into be9c59f on master.

@landscape-bot
Copy link

Code Health
Repository health increased by 0.70% when pulling 02fadfa on chacha20 into be9c59f on master.

@tomato42
Copy link
Member Author

needs adding remaining test vectors from RFC

@landscape-bot
Copy link

Code Health
Repository health increased by 0.72% when pulling 9eb1c7f on chacha20 into be9c59f on master.

@tomato42 tomato42 added the review request PR finished, ready for review label Nov 3, 2015
@tomato42
Copy link
Member Author

tomato42 commented Nov 3, 2015

@joshbressers: r?
@The-Mule: r?

@The-Mule
Copy link
Collaborator

The-Mule commented Nov 4, 2015

Reviewing, this one is pretty big, it might take a day or two.

@The-Mule
Copy link
Collaborator

OK, done, I did check the code quite carefully and I did not spot any obvious flaw. Hopefully I did not miss anything. Good work @tomato42, r+.

@tomato42
Copy link
Member Author

much appreciated, I'll merge it in the morning

tomato42 added a commit that referenced this pull request Nov 11, 2015
@tomato42
Merge pull request #34 from tomato42/chacha20
cacaf39 
Implement the ChaCha cipher
@tomato42 tomato42 merged commit cacaf39 into master Nov 11, 2015
@tomato42 tomato42 deleted the chacha20 branch November 11, 2015 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
review request PR finished, ready for review
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tomato42 @landscape-bot @The-Mule