Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixups to heartbeat support #357

Merged
merged 2 commits into from
Sep 16, 2019
Merged

fixups to heartbeat support #357

merged 2 commits into from
Sep 16, 2019

Conversation

tomato42
Copy link
Member

@tomato42 tomato42 commented Sep 13, 2019

extend heartbeat support so that it can be used in tlsfuzzer

fix few issues with message handling


This change is Reviewable

@tomato42 tomato42 added bug unintented behaviour in tlslite-ng code enhancement new feature to be implemented labels Sep 13, 2019
@tomato42 tomato42 added this to the v0.8.0 milestone Sep 13, 2019
@tomato42 tomato42 self-assigned this Sep 13, 2019
needed to verify the size of padding sent by the other side, e.g. in
tlsfuzzer
do not accept heartbeat messages with too small padding
ignore malformed messages
don't try to handle responses to requests we couldn't have sent
Copy link
Collaborator

@Jakuje Jakuje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@tomato42 tomato42 merged commit 641507a into master Sep 16, 2019
@tomato42 tomato42 deleted the heartbeat-padding-collection branch September 16, 2019 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unintented behaviour in tlslite-ng code enhancement new feature to be implemented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants