Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect pycryptodome, don't use it #408

Merged
merged 1 commit into from
May 26, 2020
Merged

detect pycryptodome, don't use it #408

merged 1 commit into from
May 26, 2020

Conversation

tomato42
Copy link
Member

@tomato42 tomato42 commented May 25, 2020

fixes #198


This change is Reviewable

@tomato42 tomato42 added the bug unintented behaviour in tlslite-ng code label May 25, 2020
@tomato42 tomato42 self-assigned this May 25, 2020
@lgtm-com
Copy link

lgtm-com bot commented May 25, 2020

This pull request fixes 1 alert when merging 1946027 into 9912a51 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented May 25, 2020

This pull request fixes 1 alert when merging d5269a3 into 9912a51 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented May 25, 2020

This pull request fixes 1 alert when merging 9efbf72 into d324e95 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@tomato42 tomato42 requested a review from Jakuje May 26, 2020 09:38
Jakuje
Jakuje previously approved these changes May 26, 2020
Copy link
Collaborator

@Jakuje Jakuje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally good. Only two nit comments along the lines.

.travis.yml Show resolved Hide resolved
tlslite/utils/cryptomath.py Show resolved Hide resolved
Copy link
Collaborator

@Jakuje Jakuje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifications. Looks good now.

@lgtm-com
Copy link

lgtm-com bot commented May 26, 2020

This pull request fixes 1 alert when merging e92ba72 into d324e95 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@tomato42 tomato42 merged commit 6355810 into master May 26, 2020
@tomato42 tomato42 deleted the pycryptodome branch May 26, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unintented behaviour in tlslite-ng code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't misdetect pycryptodome as pycrypto
2 participants