Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padding extension support to tlslite #68

Merged
merged 3 commits into from
Dec 10, 2015

Conversation

kkaarreell
Copy link
Contributor

Implements TLS extension described in RFC 7685 that can be used to pad a ClientHello with sized between 256 and 511 bytes in order to avoid implementation bugs caused by certain ClientHello sizes.

fixes #63

@kkaarreell kkaarreell force-pushed the extension-padding branch 2 times, most recently from d084062 to 2c7f3f4 Compare December 4, 2015 09:11
@kkaarreell
Copy link
Contributor Author

trailing spaces removed

@kkaarreell
Copy link
Contributor Author

Please review in a bit more detail the test if padding extension is needed in HandshakeHelpers and respective unit tests since I did a change in the condition.
ClientHello.write() size consists of 4B header (clientHello byte \x01 and length) plus the content itself. IMHO we want the content to be 512B large and therefore len(ClientHello.write()) should be 516.

@tomato42
Copy link
Member

thanks!

tomato42 added a commit that referenced this pull request Dec 10, 2015
Padding extension support to tlslite
@tomato42 tomato42 merged commit ff14000 into tlsfuzzer:master Dec 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support padding extension
2 participants