allow subclassing TLSEnum subclasses #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because both the __dict__ and vars() return the values of the current class, not all the classes in hierarchy, we need to manually traverse the hierarchy and collect all the fields ourselves this allows for extending the subclasses of TLSEnum subclasses and making both toRepr() and toStr() continue to work
tomato42
force-pushed
the
tlsenum-child-class-fix
branch
from
00e0e2d
to
18685d7
Compare
|
Looks sane, r+. |
tomato42
added a commit
that referenced
this pull request
Dec 16, 2015
allow subclassing TLSEnum subclasses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because both the
__dict__andvars()return the valuesof the current class, not all the classes in hierarchy, we need to
manually traverse the hierarchy and collect all the fields ourselves
this allows for extending the subclasses of TLSEnum subclasses and
making both toRepr() and toStr() continue to work