Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization improvements #98

Merged
merged 1 commit into from
Mar 23, 2016
Merged

Optimization improvements #98

merged 1 commit into from
Mar 23, 2016

Conversation

ioef
Copy link
Contributor

@ioef ioef commented Mar 19, 2016

read the object reference before the loop and not every-time inside it.


This change is Reviewable

read the object reference before the loop and not every-time inside it.
@tomato42
Copy link
Member

patch's ok, thanks.

could you mention, here in comment, what gains it brings?

@ioef
Copy link
Contributor Author

ioef commented Mar 20, 2016

Hi Hubert.

Well in my local file i have applied this approach in more than one place
in the code and i have achieved significant improvements in the througput
speed of the AES128GCM. I am currently attaching the file that you may
have a look at and maybe also apply in your main track.

Please have a look at the below results

Test 1: aes128gcm python: 1MB exchanged at rate of 201525 bytes/sec
Used Ciphersuite: TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256

Test 2: aes128 python: 1MB exchanged at rate of 312258 bytes/sec
Used Ciphersuite: TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256

Test 3: aes256 python: 1MB exchanged at rate of 238730 bytes/sec
Used Ciphersuite: TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA

Test 4: rc4 python: 1MB exchanged at rate of 2010652 bytes/sec
Used Ciphersuite: TLS_ECDHE_RSA_WITH_RC4_128_SHA

Test 5: chacha20-poly1305 python: 1MB exchanged at rate of 283674 bytes/sec
Used Ciphersuite: TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305

Test 6: speck128 python: 1MB exchanged at rate of 318835 bytes/sec
Used Ciphersuite: TLS_ECDHE_RSA_WITH_SPECK_128_CBC_SHA256

Test 7: speck128gcm python: 1MB exchanged at rate of 202298 bytes/sec
Used Ciphersuite: TLS_ECDHE_RSA_WITH_SPECK_128_GCM_SHA256

Test 8: speck192gcm python: 1MB exchanged at rate of 199748 bytes/sec
Used Ciphersuite: TLS_ECDHE_RSA_WITH_SPECK_192_GCM_SHA256

Test succeeded, 8 good

2016-03-20 11:11 GMT+02:00 Hubert Kario notifications@github.com:

patch's ok, thanks.

could you mention, here in comment, what gains it brings?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#98 (comment)

@tomato42
Copy link
Member

I meant for this patch only, baseline and with it...

@ioef
Copy link
Contributor Author

ioef commented Mar 20, 2016

Would you like me to apply the updates in the aesgcm file according to the
file i have provided?

Thank you.

2016-03-20 13:33 GMT+02:00 Hubert Kario notifications@github.com:

I meant for this patch only, baseline and with it...


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#98 (comment)

@tomato42
Copy link
Member

github does not attach any patches, so I have not seen that file.

I'm still asking for a comparison between current master branch and this patch only

@ioef
Copy link
Contributor Author

ioef commented Mar 20, 2016

I have just provided you the file updates through your email. Thank you.

@tomato42 tomato42 merged commit 5ba5015 into tlsfuzzer:master Mar 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants