Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "center" variable can't use a "-" on his key name #385

Closed
moretti opened this issue Jun 4, 2014 · 7 comments
Closed

The "center" variable can't use a "-" on his key name #385

moretti opened this issue Jun 4, 2014 · 7 comments
Milestone

Comments

@moretti
Copy link

moretti commented Jun 4, 2014

What is the reason behind this check?

if (attrs.center.search('-') !== -1) {
  $log.error('The "center" variable can\'t use a "-" on his key name: "' + attrs.center + '".');

It breaks a configuration like this one:

<leaflet center="{'lat': 51.508515, 'lng':-0.1254872, 'zoom':12}"><leaflet>
@nmccready
Copy link
Contributor

I did see this in the code base and thought it was interesting as well. @tombatossals thoughts?

@nmccready nmccready added this to the 0.8.9 milestone Sep 5, 2015
@simison
Copy link
Contributor

simison commented Sep 17, 2015

PS. A good reminder to comment code better. ;-)

@nmccready
Copy link
Contributor

Or better yet use a function with proper naming that explains what it does.

@simison
Copy link
Contributor

simison commented Sep 17, 2015

Totally. 👍

@nmccready
Copy link
Contributor

Bumping this to 0.9.1

@nmccready
Copy link
Contributor

This issue was moved to angular-ui/ui-leaflet#23

@tombatossals
Copy link
Owner

I'm going to rework&redesign angular-leaflet-directive to be compatible with Leaflet v1.0. It will mantain almost all its functionality, and will be compatible with the current features of the directive, but I must start from a fresh point, so I'm going to close this issue. If you think it must be worked with the new version, please reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants