Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent default retries #3

Closed
wernight opened this issue Mar 4, 2015 · 3 comments
Closed

Inconsistent default retries #3

wernight opened this issue Mar 4, 2015 · 3 comments

Comments

@wernight
Copy link

wernight commented Mar 4, 2015

On https://www.npmjs.com/package/attempt it shows Default: 5. The number of times to retry.

On https://github.com/TomFrost/node-attempt it shows Default: 2. The number of times to retry.

@TomFrost
Copy link
Owner

TomFrost commented Mar 4, 2015

Thanks for pointing this out! Waiting for this resolution before I can publish the fix: npm/npm#7520

@wernight
Copy link
Author

wernight commented Mar 5, 2015

Diverging a bit, but isn't 2 retries meaning it may actually do the operation 3 times? In that case I'd suggest to change so that it's the total number of attempts (i.e., 3 or 6 by default).

@TomFrost
Copy link
Owner

NPM and Github are now in sync with default retries. Thanks for the wording suggestion! I've updated the README on Github with the clarification (will go to NPM with the next patch). I'm open to deprecating the 'retries' option and, instead, sending in something like totalAttempts, but since that would be a minor release instead of just a patch, I wanted to get the patch out now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants