Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a wallet for each user #2

Open
tomislavmamic opened this issue Jun 12, 2024 · 6 comments
Open

create a wallet for each user #2

tomislavmamic opened this issue Jun 12, 2024 · 6 comments

Comments

@tomislavmamic
Copy link
Member

When a user creates an in-app account, they also get and Ethereum account and a wallet to interact with it. User can't use external wallet. User can't use wallet for anything else than what is intended within the app.

Feature: Wallet
  As a user
  I want to have a wallet
  Because I want to hold currency and make transactions

  Scenario: User sees his token balance
    Given I'm not logged in
    When I open start page
    Then I can see my token balance
    
@tomislavmamic tomislavmamic added this to the Starter feature set milestone Jun 12, 2024
@tomislavmamic tomislavmamic changed the title Wallet User has a wallet Jun 12, 2024
@tomislavmamic tomislavmamic changed the title User has a wallet add wallets for users Jun 12, 2024
@tomislavmamic tomislavmamic changed the title add wallets for users create wallets for users Jun 12, 2024
@tomislavmamic tomislavmamic changed the title create wallets for users create a wallet for each user Jun 12, 2024
@b0rza
Copy link
Member

b0rza commented Jul 1, 2024

@tomislavmamic why can't they use an external wallet?

@tomislavmamic
Copy link
Member Author

@tomislavmamic why can't they use an external wallet?

Multiple reasons:

  1. For now, this will help us decrease the complexity, and simplify the UI for the user
  2. We are targeting new users with this project, existing crypto users aren't our focus, but they can transfer funds from their existing wallet if they want to use this app, this will be only a small nuisance for them
  3. Most of existing crypto users probably wouldn't want to have a KYC on their existing wallet for a one off donation
  4. With Connect we can actually control what a user can do. Although the wallet is non-custodial, if I understood correctly, we can prevent user from accessing the wallet if we want. This is useful in cases of scam/fraud attempts.

@b0rza
Copy link
Member

b0rza commented Jul 1, 2024

Makes sense, I was thinking about knowledgeable users. But if they are not a focus for v1 or this at all, I agree it's not needed.

@kkatusic
Copy link
Collaborator

kkatusic commented Jul 3, 2024

@tomislavmamic if we use cometh.io wallet option, they can connect to app using existing wallet, for example MetaMask or we will disable that?

@tomislavmamic
Copy link
Member Author

tomislavmamic commented Jul 4, 2024 via email

@kkatusic
Copy link
Collaborator

kkatusic commented Jul 4, 2024

Ok

b0rza pushed a commit that referenced this issue Aug 27, 2024
b0rza pushed a commit that referenced this issue Sep 12, 2024
b0rza pushed a commit that referenced this issue Sep 12, 2024
b0rza pushed a commit that referenced this issue Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants