Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the language picker should take you to index.html if translated, but doesn't #35

Open
cannikin opened this issue Jan 21, 2021 · 1 comment

Comments

@cannikin
Copy link
Contributor

Right now, even if index.html is translated, changing language will take you to the latest version of the spec. It should take you to the translated index.html:

Steps to Reproduce

  1. Choose 简体中文 as your language
  2. Page redirects to https://deploy-preview-34--toml-io.netlify.app/cn/v1.0.0

Expected Behavior

Should redirect to https://deploy-preview-34--toml-io.netlify.app/cn/

@cannikin cannikin changed the title Changing the language picker should take you to index.html if translated Changing the language picker should take you to index.html if translated, but doesn't Jan 21, 2021
@LongTengDao
Copy link
Contributor

LongTengDao commented Jan 27, 2021

Supplement:

  1. When click Version -> v1.0.0 from toml.io/cn/, the page should go to toml.io/cn/v1.0.0, but currently it is always toml.io/en/v1.0.0.
  2. In page toml.io/cn/, the button Version need to have a way to show i18n content in translated index.html.
  3. Maybe English should be the first option in languages select menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants