Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend Unit Tests #21

Closed
RyanH1234 opened this issue Apr 3, 2020 · 4 comments · Fixed by #28
Closed

Frontend Unit Tests #21

RyanH1234 opened this issue Apr 3, 2020 · 4 comments · Fixed by #28
Assignees
@RyanH1234
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed

Comments

@RyanH1234
Copy link
Collaborator

Need to find an appropriate library that can do testing. I don't think actually testing the code will help us since it's so tightly coupled with the UI and the Splunk database, but maybe a library which can test UI interactions? Need to research this.
@RyanH1234 RyanH1234 added documentation Improvements or additions to documentation help wanted Extra attention is needed labels Apr 3, 2020
@RyanH1234 RyanH1234 self-assigned this Apr 3, 2020
@RyanH1234
Copy link
Collaborator Author

Selenium? Does it need node though..if it does then that's a pain

@Tommoa
Copy link
Owner

Tommoa commented Apr 5, 2020

I've also briefly looked at QUnit, but I think it also needs node.

We can quite easily install node as a part of our CI if we need to though

@RyanH1234
Copy link
Collaborator Author

Yeah that's what I'm thinking - I'll have a play with this. Really we just need one unit test up and running for now, just to show we can actually do it

@RyanH1234
Copy link
Collaborator Author

Three "proper" working unit tests have been added demonstrating how to use QUnit with SPA

@Tommoa Tommoa linked a pull request Apr 25, 2020 that will close this issue
Feat/unit tests #28
Merged
@Tommoa Tommoa closed this as completed Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RyanH1234 RyanH1234

Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/unit tests Tommoa/SPA
2 participants
@Tommoa @RyanH1234