Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible typo in docs regarding complexity of FFTKDE #47

Closed
rdimaio opened this issue Apr 9, 2020 · 1 comment · Fixed by #48
Closed

Possible typo in docs regarding complexity of FFTKDE #47

rdimaio opened this issue Apr 9, 2020 · 1 comment · Fixed by #48

Comments

@rdimaio
Copy link
Contributor

rdimaio commented Apr 9, 2020

Hi,

In FFTKDE's docs (https://kdepy.readthedocs.io/en/latest/API.html#KDEpy.FFTKDE.FFTKDE), the time complexity for the first phase is given as O(N*(2^d)) and for the second phase as (Onlogn); the total running time is then given as O(N(d^2)+nlogn). I am not sure if the N(d^2) in the total running time is a typo (d^2 instead of 2^d) or if I am just misunderstanding something. Thank you again for implementing this, by the way! It's extremely useful 😄

@tommyod
Copy link
Owner

tommyod commented Apr 9, 2020

You are correct! It should be 2 to the power of d. You are welcome to create a PR!

@rdimaio rdimaio mentioned this issue Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants