Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert value and gas to hex #384

Merged
merged 1 commit into from
Dec 19, 2018
Merged

Convert value and gas to hex #384

merged 1 commit into from
Dec 19, 2018

Conversation

thanhnguyennguyen
Copy link
Contributor

@thanhnguyennguyen thanhnguyennguyen commented Dec 19, 2018 •
edited
Loading

Hi a. @thanhson1085
Could you please arrange your time help to review this pull request ?

Changes in this PR:

  • Update value, gas, gasPrice to hex

Tested scenarios:

  • Vote, Unvote, Apply, Resign, Withdraw using Ledger and Private key

@thanhson1085 thanhson1085 self-requested a review December 19, 2018 03:13
@coveralls
Copy link

Pull Request Test Coverage Report for Build 716

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.47%
Totals Coverage Status
Change from base Build 712: 0.0%
Covered Lines: 92
Relevant Lines: 103
💛 - Coveralls

@thanhson1085 thanhson1085 merged commit a89703a into master Dec 19, 2018
@thanhnguyennguyen thanhnguyennguyen deleted the convert-value-and-gas-to-hex branch January 30, 2019 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thanhson1085 thanhson1085 thanhson1085 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thanhnguyennguyen @coveralls @thanhson1085