Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a Median Filter for Non-Finite Values #566

Merged
merged 33 commits into from
Nov 11, 2021
Merged

Adding a Median Filter for Non-Finite Values #566

merged 33 commits into from
Nov 11, 2021

Commits on Nov 1, 2021

  1. Adding in median filter for non-finite values in 3D array

    @WilliamJudge94
    WilliamJudge94 committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    a118409 View commit details
    Browse the repository at this point in the history

  2. Formatting for PEP8

    @WilliamJudge94
    WilliamJudge94 committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    cbe645e View commit details
    Browse the repository at this point in the history

  3. Updating PEP8v2

    @WilliamJudge94
    WilliamJudge94 committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    bd53fba View commit details
    Browse the repository at this point in the history

  4. Update source/tomopy/misc/corr.py 

    Adding _ to the find_nonfinite_values_prj function since it is not intended to be used by the User

Co-authored-by: Daniel Ching <carterbox@users.noreply.github.com>
    @WilliamJudge94 @carterbox
    WilliamJudge94 and carterbox committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    7e8de93 View commit details
    Browse the repository at this point in the history

  5. Update source/tomopy/misc/corr.py 

    Adding _ to the determine_nonfinite_kernel_idxs function since it is not intended to be used by the User

Co-authored-by: Daniel Ching <carterbox@users.noreply.github.com>
    @WilliamJudge94 @carterbox
    WilliamJudge94 and carterbox committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    79be52b View commit details
    Browse the repository at this point in the history

  6. Updating median_filter_nonfinite to not require tqdm

    @WilliamJudge94
    WilliamJudge94 committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    040be55 View commit details
    Browse the repository at this point in the history

  7. Accidentally left tqdm inside imports - removing with commit

    @WilliamJudge94
    WilliamJudge94 committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    e5ee919 View commit details
    Browse the repository at this point in the history

  8. Adding function to __all__ and adding authors name

    @WilliamJudge94
    WilliamJudge94 committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    832a4b2 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2021

  1. Adding a CallbackClass to median_filter_nonfinite and adding testing … 

    …for function
    @WilliamJudge94
    WilliamJudge94 committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    d7d3e3e View commit details
    Browse the repository at this point in the history

  2. Fixing test formatting for median_filter_nonfinite()

    @WilliamJudge94
    WilliamJudge94 committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    13578a8 View commit details
    Browse the repository at this point in the history

  3. DOC: use consistent type descriptions

    @carterbox
    carterbox committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    6f79b9e View commit details
    Browse the repository at this point in the history

  4. Use callback funtion instead of CallbackClass for median_filter_nonfi… 

    …nite
    @WilliamJudge94
    WilliamJudge94 committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    b869833 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' of github.com:WilliamJudge94/tomopy

    @WilliamJudge94
    WilliamJudge94 committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    850e045 View commit details
    Browse the repository at this point in the history

  6. Correcting the median_filter_nonfinite function description

    @WilliamJudge94
    WilliamJudge94 committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    aa3a4c0 View commit details
    Browse the repository at this point in the history

  7. TST: Test all sorts of nonfinite values

    @carterbox
    carterbox committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    70cf4e8 View commit details
    Browse the repository at this point in the history

  8. DOC: Refactor docstrings for median filter nonfinite

    @carterbox
    carterbox committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    afa195d View commit details
    Browse the repository at this point in the history

  9. Updating median_filter_nonfinite test

    @WilliamJudge94
    WilliamJudge94 committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    f33ebac View commit details
    Browse the repository at this point in the history

  10. REF: Parameterize filter size consistently with other functions 

    It is convention to use filter size as the width of the filter
not the radius.
    @carterbox
    carterbox committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    2383519 View commit details
    Browse the repository at this point in the history

  11. TST: Test that all values are correct instead of just one

    @carterbox
    carterbox committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    2e8b430 View commit details
    Browse the repository at this point in the history

  12. Adding self argument to test

    @WilliamJudge94
    WilliamJudge94 committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    74aa99f View commit details
    Browse the repository at this point in the history

  13. REF: Remove unnecessary variable declarations

    @carterbox
    carterbox committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    af94d9d View commit details
    Browse the repository at this point in the history

  14. BUG: it is valid for a range end to equal the shape

    @carterbox
    carterbox committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    7140bd7 View commit details
    Browse the repository at this point in the history

  15. STY: Format whitespace

    @carterbox
    carterbox committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    102d60e View commit details
    Browse the repository at this point in the history

  16. Merge remote-tracking branch 'refs/remotes/WilliamJudge94/master' int… 

    …o pr/WilliamJudge94/566
    @carterbox
    carterbox committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    6fc733c View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2021

  1. Replacing _determine_nonfinite_kernel_idxs with min()/max()

    @WilliamJudge94
    WilliamJudge94 committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    05a887c View commit details
    Browse the repository at this point in the history

  2. Adding kernel ValueError to median_filter_nonfinite() + coorrespondin… 

    …g tests + removing unused functions
    @WilliamJudge94
    WilliamJudge94 committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    2deaae4 View commit details
    Browse the repository at this point in the history

  3. BUG: Fixing variable name bug

    @WilliamJudge94
    WilliamJudge94 committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    4d2ce3b View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2021

  1. BUG: Prevent filter sweep in median_nonfinite 

    Modifies tests so that they force the correct ValueError. Ensure that
ValueError is always raised when there is a group of nonfinites larger
than or equal to the filter size. Without making a copy of the current
slice, filters would use already filtered values in the filter.
    @carterbox
    carterbox committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    5c020e2 View commit details
    Browse the repository at this point in the history

  2. STY: Wrap lines at 80 chars

    @carterbox
    carterbox committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    e5f82f7 View commit details
    Browse the repository at this point in the history

  3. STY: Remove unused parameters

    @carterbox
    carterbox committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    4f6644a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into master

    @carterbox
    carterbox committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    79cff50 View commit details
    Browse the repository at this point in the history

  5. DOC: Update docs and match new API with existing filter funcs

    @carterbox
    carterbox committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    b642265 View commit details
    Browse the repository at this point in the history

  6. DOC: versionadded tags to documentation

    @carterbox
    carterbox committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    301ee36 View commit details
    Browse the repository at this point in the history