Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize exception handling #8

Closed
Maxitet opened this issue Aug 22, 2021 · 0 comments · Fixed by #18
Closed

Generalize exception handling #8

Maxitet opened this issue Aug 22, 2021 · 0 comments · Fixed by #18
Assignees
@TomSuworof
Labels
backend This issue relates to backend scope
Milestone
MVP

Comments

@Maxitet
Copy link
Collaborator

Maxitet commented Aug 22, 2021

After migration to Vue frontend need to generalize exceptions and exception handling. Exceptions should be handled in places where it'll make most sense. As much close to cause as it possible.

  1. Check Spring's @ControllerAdvice. It'll help to map exception to response.
  2. Create error message model (class or group of classes). It can contain error message and error code(-s) that will be returned from backend.
@Maxitet Maxitet added the backend This issue relates to backend scope label Aug 22, 2021
@Maxitet Maxitet added this to the MVP milestone Aug 22, 2021
TomSuworof added a commit that referenced this issue Aug 30, 2021
@TomSuworof
closes #8. ControllerAdvices were added for global exception handling
f3dcbe4
@TomSuworof TomSuworof linked a pull request Aug 30, 2021 that will close this issue
closes #8. Feature 8 exception handling #18
Merged
TomSuworof added a commit that referenced this issue Aug 31, 2021
@TomSuworof
closes #8. Field email was added in admin dashboard
4096228
TomSuworof added a commit that referenced this issue Sep 9, 2021
@TomSuworof
closes #8. Unnecessary classes removed
75e2b15
TomSuworof added a commit that referenced this issue Sep 10, 2021
@TomSuworof
closes #8. Logger was added, Http Code for duplicated content was cha…
0ede11e 
…nged from 303 to 422
TomSuworof added a commit that referenced this issue Sep 11, 2021
@TomSuworof
closes #8. Error serialization by class ErrorResponse
a1bfd9f
TomSuworof added a commit that referenced this issue Sep 11, 2021
@TomSuworof
closes #8. Added ControllerAdvice for constraint violation
adb5820
Maxitet added a commit that referenced this issue Sep 11, 2021
@Maxitet
Merge pull request #18 from TomSuworof/feature-8-exceptions
818b542 
closes #8. Feature 8 exception handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TomSuworof TomSuworof

Labels
backend This issue relates to backend scope
Projects
None yet
Milestone
MVP
Development

Successfully merging a pull request may close this issue.

closes #8. Feature 8 exception handling TomSuworof/briene
2 participants
@Maxitet @TomSuworof