-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chain methods to MidiConvert.d.ts #18
Comments
@appsforartists, I'm adding at least some of these now. I just realized how much is missing from that typings file, lol. I'm almost tempted to convert the entire project to a typescript project so it can autogen and be up-to-date always.... Hmm.... |
My general philosophy is that typings should match the documentation; since the README doesn't include the chains, the typings didn't either. In general, I would float proposals by @tambien before PRing them. We of course appreciate help, but changing tabs to spaces or converting the project to a different toolchain are big steps to take without confirming they are desired. |
Well, my general philosophy is that typings should match the code: i.e. when your code tries to compile but can't because of a faulty .d.ts file (https://gyazo.com/e0a9aa8cf11f3c97c7e95f7f6a413778), no amount of having a slightly different "philosophy" is going to help you... lol. In addition, the pic is an example literally taken from the documentation anyways, lol (https://gyazo.com/8e1fb29cf0df442da24774b64f51be1f). I can't convince myself that this is intentional. It was either written incorrectly or out-of-date / incomplete. Given the existence of this thread, it seems to be the latter. Forget the typescript thing. It wasn't that serious. Not sure what you mean about changing tabs to spaces. |
updated api and d.ts file. i don't think this issue is relevant any longer. closing, but feel free to open it if there is still an issue. |
I was unaware of the chainable methods when I wrote the d.ts file; they are currently not documented there.
The text was updated successfully, but these errors were encountered: