-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot minify build with Create React APP #49
Comments
@gaearon curious about your thoughts here. ES2015 has been well supported across browsers for years, so I'm not terribly inclined to translate our builds to ES5. The operative word in your docs is if, but I'm not sure if there's an alternative when a package doesn't support ES5 (other than to fork, as you mention later in those docs). |
I just looked at the |
Hello @appsforartists Would you like me to open the issue over at the React repository? |
If you want to, sure. It would be the create-react-app repo, and I don't know what they'd do. As I understand it, CRA is supposed to be a zero-config starter, which means there isn't a place to add exceptions. But, requiring all dependencies to be ES5 seems heavyhanded, especially if you're importing from ES2015 modules. At the very least, I think they ought to fall back to |
When a blank Create React App is created and MidiConvert is a dependency, it is fine for developing. As soon as a build is started it gives the following error:
In the package.json from MidiConvert the following entry triggers the build of the source files.
"module": "src/MidiConvert.js",
When removed, the React project builds.
React project implementing MidiConvert.
Package JSON with erroring line of MidiConvert.
The text was updated successfully, but these errors were encountered: