add Double to StackValueKind enum (dotnet#5011)

tonerdo · Sep 4, 2018 · d7cc694 · d7cc694
1 parent 0dc4175
commit d7cc694
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/src/Common/src/TypeSystem/IL/ILImporter.cs b/src/Common/src/TypeSystem/IL/ILImporter.cs
@@ -24,6 +24,8 @@ internal enum StackValueKind
         NativeInt,
         /// <summary>Any float value.</summary>
         Float,
+        /// <summary>Any double value.</summary>
+        Double,
         /// <summary>A managed pointer.</summary>
         ByRef,
         /// <summary>An object reference.</summary>

diff --git a/src/System.Private.Interpreter/src/Internal/Runtime/Interpreter/ILImporter.Interpreter.cs b/src/System.Private.Interpreter/src/Internal/Runtime/Interpreter/ILImporter.Interpreter.cs
@@ -232,6 +232,7 @@ private void ImportReturn()
                 case TypeFlags.FunctionPointer:
                 case TypeFlags.GenericParameter:
                 default:
+                    // TODO: Support more complex return types
                     break;
             }
         }

diff --git a/src/System.Private.Interpreter/src/Internal/Runtime/Interpreter/StackItem.cs b/src/System.Private.Interpreter/src/Internal/Runtime/Interpreter/StackItem.cs
@@ -85,7 +85,7 @@ public float AsFloat()
 
         public static StackItem FromDouble(double d)
         {
-            return new StackItem { _double = d, _kind = StackValueKind.Float };
+            return new StackItem { _double = d, _kind = StackValueKind.Double };
         }
 
         public double AsDouble()