Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

::< looks weird #1145

Closed
Veykril opened this issue Oct 29, 2020 · 6 comments
Closed

::< looks weird #1145

Veykril opened this issue Oct 29, 2020 · 6 comments
Labels
Milestone

Comments

@Veykril
Copy link

Veykril commented Oct 29, 2020

In Rust there is a so called turbofish operator which is used by generic function calls which makes use of the character sequence ::<. Unfortunately FiraCode causes this sequence to look a bit weird due to the font ligatures moving the middle colon up a bit:
grafik
I imagine this is due to the fact that :< is considered a ligature in the other category, but I wonder if it would be possible to have this behaviour reset for the ::< character case given that the two colons are just scoping operators here, assuming this is possible.

@tonsky
Copy link
Owner

tonsky commented Oct 29, 2020

Thank you for reporting, I’ll take a look!

@tonsky tonsky added this to the 6 milestone Oct 29, 2020
@aaronbell
Copy link

I found this yesterday too. I think it can be solved fairly easily by adding in an extra ignore to the center lookup (line 731):
ignore sub colon colon' [less greater]; # ignores the ::< case

@jhpratt
Copy link

jhpratt commented Jul 12, 2021

@tonsky Any plans for a new release? It's a shame this patch has been merged for a few months and it's not out yet. No big deal either way, just curious.

@tonsky
Copy link
Owner

tonsky commented Jul 12, 2021

Yes, new release will come shortly

@jhpratt
Copy link

jhpratt commented Jul 12, 2021

Awesome. Thanks for the quick response!

@dtolnay
Copy link

dtolnay commented Nov 30, 2021

Released in https://github.com/tonsky/FiraCode/releases/tag/6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants