Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pipe | shorter #843

Closed
tonsky opened this issue Sep 16, 2019 · 11 comments
Closed

Make pipe | shorter #843

tonsky opened this issue Sep 16, 2019 · 11 comments
Milestone

Comments

@tonsky
Copy link
Owner

tonsky commented Sep 16, 2019

Thanks for the good work. But in my personal opinion, the new | seems too tall in normal code. Now the || is way taller than &&, which seems inconsistent. Also, some related ligatures is inconsistent to this taller |, like |=

2019-09-15_11-24-04


EDIT: I'm talking about the ASCII symbol | (U+007C) instead of the BOX DRAWINGS LIGHT VERTICAL (U+2502). In v2.0, the | (U+007C) becomes taller, which I think is a mistake.

Originally posted by @blahgeek in #449 (comment)

@tonsky
Copy link
Owner Author

tonsky commented Sep 16, 2019

It became taller to match full block height in progressbar:

     |████████████████████████████████| 102kB 4.6MB/s 

Maybe it’s not such a good idea.

@tonsky tonsky added this to the 3 milestone Sep 16, 2019
@tonsky
Copy link
Owner Author

tonsky commented Sep 16, 2019

Actually now I’m thinking that I can detect that specific case and alter the height in that case only

@blahgeek
Copy link

I think a proper progress bar should use U+2502 instead of U+007C anyway

@tonsky
Copy link
Owner Author

tonsky commented Sep 16, 2019

Tell that to pip authors :)

@j-f1
Copy link
Contributor

j-f1 commented Sep 16, 2019

Actually now I’m thinking that I can detect that specific case and alter the height in that case only

What about when the bar isn’t all the way full?

 |████████████████████████        | 102kB 4.6MB/s 

@tonsky
Copy link
Owner Author

tonsky commented Sep 17, 2019

Yeah, bad idea. Shame :(

@JakobBruenker
Copy link

I actually quite liked it last time I used a font with vertical bars this long, specifically for haskell's guards, and I like it here as well:

(github file attachment doesn't seem to work for me at the moment, so here's an imgur link)
https://i.imgur.com/KxQWNOU.png

If you end up removing it, maybe consider leaving it in as a stylistic set, I would appreciate it.

@tonsky
Copy link
Owner Author

tonsky commented Sep 26, 2019

Looks great in your screenshot. Thanks for that use-case!

Losangelosgenetics pushed a commit to Losangelosgenetics/FiraCode that referenced this issue Mar 13, 2020
@tonsky tonsky modified the milestones: 3, 4 Apr 9, 2020
@tonsky tonsky modified the milestones: 4, 5 May 16, 2020
@tonsky tonsky modified the milestones: 5, 6 Jun 9, 2020
@carlsmith
Copy link

Another vote for keeping the bar full-height.

@rumpelsepp
Copy link

rumpelsepp commented Sep 24, 2020

htop is a bit hard to read with these long pipes:

latest

vs. Hack

latest

edit: I have a 4k monitor. The gap between the bars disappears with lower resolutions.

@tonsky tonsky closed this as completed in 28fb42c Oct 11, 2020
@gyzerok
Copy link

gyzerok commented Nov 29, 2021

Actually long bar was looking weird in Rust lambdas - .filter(|x| { x == x }), so the change is very nice. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants