Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form controls generate React warnings #6

Closed
mdhaney opened this issue Jan 11, 2015 · 4 comments
Closed

Form controls generate React warnings #6

mdhaney opened this issue Jan 11, 2015 · 4 comments

Comments

@mdhaney
Copy link

mdhaney commented Jan 11, 2015

Using any HTML form controls, e.g. [:input] causes React to emit the following warnings:

Warning: Something is calling a React component directly. Use a factory or JSX instead. See: http://fb.me/react-legacyfactory

Warning: transferPropsTo is deprecated. See http://fb.me/react-transferpropsto for more information.

I spent some time tracking this down to make sure it wasn't something I was doing wrong, and I found the problem in sablono. They create a new React component to wrap each form control, and they are using createClass instead of createElement. This has been fixed in master, although I could not get my app to build using the 3.0.0-snapshot version published to clojars.

I created this issue mainly as a heads up for anyone else who runs into it, so they know that it's expected behavior and nothing is wrong. Also, maybe this can serve as a reminder to update the sablono dependency when they release a new version.

@tonsky
Copy link
Owner

tonsky commented Jan 11, 2015

Amazing, thanks for the enquiry! Very useful

@tonsky
Copy link
Owner

tonsky commented Jan 18, 2015

Waiting for 0.3.0: r0man/sablono#47

@tonsky
Copy link
Owner

tonsky commented Jan 28, 2015

@peeb updated deps to Sablono 0.3.1 in 08e076c, pushed [rum "0.2.1"] to clojars

@tonsky tonsky closed this as completed Jan 28, 2015
@mdhaney
Copy link
Author

mdhaney commented Jan 28, 2015

Very nice. I'll try it out tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants