Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rum.core/derived-atom without docs #84

Closed
madstap opened this issue Jul 12, 2016 · 5 comments
Closed

rum.core/derived-atom without docs #84

madstap opened this issue Jul 12, 2016 · 5 comments

Comments

@madstap
Copy link
Contributor

madstap commented Jul 12, 2016

rum.derived-atom/derived-atom has a nice docstring, but it doesn't transfer over to rum.core/derived-atom, which appears to be undocumented. A fix could be to move the docstring to the def in rum.core.

@tonsky
Copy link
Owner

tonsky commented Jul 12, 2016

Please provide a PR :)

@madstap
Copy link
Contributor Author

madstap commented Jul 12, 2016

When I'm already messing around with this particular fns metadata, would you accept that I add indentation metadata as well, so that emacs (and eventually, hopefully, other editors) indent it like:

  (def *x (derived-atom [*a *b] ::key
            (fn [a b]
              (str a \":\" b))))

instead of the current

(def *x (derived-atom [*a *b] ::key
                      (fn [a b]
                        (str a \":\" b))))

@tonsky
Copy link
Owner

tonsky commented Jul 12, 2016

sure

@madstap
Copy link
Contributor Author

madstap commented Jul 12, 2016

PR provided :)

@tonsky
Copy link
Owner

tonsky commented Jul 12, 2016

Thanks! Closed in #85

@tonsky tonsky closed this as completed Jul 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants