Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape attributes in server-side #93

Closed
tonsky opened this issue Aug 8, 2016 · 1 comment
Closed

Escape attributes in server-side #93

tonsky opened this issue Aug 8, 2016 · 1 comment
Labels
ssr JVM rendering issues

Comments

@tonsky
Copy link
Owner

tonsky commented Aug 8, 2016

By @dwwoelfel:

I noticed that attributes aren't escaped when Rum builds html with its server-side rendering.

For example,

[:div {:className "\"><script>alert('hi')</script>"}]

is perfectly safe on the cljs side, but will alert if it's rendered on the server.

@CmdrDats
Copy link

CmdrDats commented Nov 8, 2016

+1 for this, having to manually escape this is a little painful - in my case, I'm doing a {:data-model (pr-str model)} on a tag to transfer the initial model into the components when the clojurescript upgrades the components to react.

@roman01la roman01la added the ssr JVM rendering issues label Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ssr JVM rendering issues
Projects
None yet
Development

No branches or pull requests

3 participants