Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove registration timeout and retry logic #58

Closed
erwa opened this issue Oct 29, 2018 · 1 comment
Closed

Remove registration timeout and retry logic #58

erwa opened this issue Oct 29, 2018 · 1 comment
Assignees

Comments

@erwa
Copy link
Contributor

erwa commented Oct 29, 2018

Currently, there are a couple timeouts involved in worker/parameter server registration:

  • tony.task.registration-timeout-sec (default 300 sec)
  • 120 sec polling until non-null in TaskExecutor.registerAndGetClusterSpec()
    return Utils.pollTillNonNull(() ->
        proxy.registerWorkerSpec(jobName + ":" + taskIndex,
            InetAddress.getLocalHost().getHostName() + ":" + rpcPort), 3, 120);

If there are large container scheduling/start-up delays, jobs can fail due to this. We should remove these timeouts entirely. We also then don't need the tony.task.registration-retry-count property either.

@erwa
Copy link
Contributor Author

erwa commented Nov 7, 2018

Internal JIRA: LIHADOOP-42079

erwa pushed a commit to erwa/TonY that referenced this issue Nov 7, 2018
@erwa erwa closed this as completed in #69 Nov 7, 2018
erwa added a commit that referenced this issue Nov 7, 2018
* Remove registration timeout and retry logic #58

* Fix TestTonyConfigurationFields.testCompareXmlAgainstConfigurationClass test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant