react: add plotly.js #1153
Merged
react: add plotly.js #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony
force-pushed
the
v2-plotly
branch
6 times, most recently
from
a836576
to
f9c9fa3
Compare
tony
force-pushed
the
v2
branch
3 times, most recently
from
5f3bd11
to
8b23c80
Compare
tony
force-pushed
the
v2-plotly
branch
3 times, most recently
from
08c5dde
to
854fada
Compare
tony
force-pushed
the
v2-plotly
branch
6 times, most recently
from
0bce049
to
f005483
Compare
tony
force-pushed
the
v2-plotly
branch
3 times, most recently
from
4953ffb
to
eb26ccf
Compare
tony
force-pushed
the
v2-plotly
branch
12 times, most recently
from
0fe4718
to
97196a6
Compare
tony
force-pushed
the
v2-plotly
branch
8 times, most recently
from
10b654e
to
eeed569
Compare
tony
force-pushed
the
v2-plotly
branch
3 times, most recently
from
69dbde1
to
d9b823c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging URL: https://cv-react-v2.git-pull.com/dev/branch/v2-plotly/
https://plotly.com/javascript/
https://github.com/plotly/plotly.js
Good things:
Ugly things:
Animating / transitions is a joke. Other chart libs are beautiful out of the box.
Donut charts don't seem toe animate at all (2020-01-02). The line chart updates are really flakey. This surprised for me for a framework that otherwise did very well
Lack of callbacks for formatting labels, colors. You have to render the array yourself, and don't have access to the context passed by chart (so you have to calculate the % of a pie on your own)
On the tracker, some in the community espoused an attitude of "this is for scientific data" (that's fine), but contraposed against rationale appreciate sensible API aesthetics and development happiness in the lib itself 😬 Why sabotage what could be a good thing?
What does being scientific have to do with hiding labels? It's styling. Is there a secret principle in science where people need this?
My workaround: First, second approach with TypeScript friendliness
Packaged very oddly, so the library may simply cease to work for some
Native ES6 modules vs. the bundle plotly/plotly.js#3518 (comment)
The issue has a $10,000-$15,000 bounty
I support this project commercially funding itself. I support them earning a profit. But it's really painful when theirs internal architectural changes in such a big project. I feel for them.
As of 2020-01-02, when I click on sandboxes for react-plotly.js, they should
documentnot found.Tweaks:
[@types/plotly.js]: Add missing automargin prop to data DefinitelyTyped/DefinitelyTyped#50363 - Typing for @types/plotly.js and
automargin(plotly.js example)https://github.com/plotly/graphing-library-docs - doc typo fix
https://gist.github.com/tony/f0938e379aef3c49648a2b1b63e00807 / Concept for plotly.js with Functional component, TypeScript plotly/react-plotly.js#226: Custom React wrapper
Sandbox: https://codesandbox.io/s/react-plotlyjs-minimal-c6k7f