biome

.github/workflows/tests.yaml

@@ -22,11 +22,7 @@ jobs:
       - name: pull gh repos
         run: |
           env GITHUB_API_TOKEN=${{ secrets.CI_GITHUB_API_TOKEN }} yarn workspace @tony/cv-scripts run github
-      - name: prettier --check . - all
-        run: yarn prettier --check .
-      - name: eslint - lib
-        run: yarn workspace @tony/cv-lib run -T lint
-      - name: eslint - react
-        run: yarn workspace @tony/cv-react run -T lint
-      - name: eslint - all
-        run: yarn lint
+      - name: yarn biome format .
+        run: yarn biome format .
+      - name: yarn biome lint .
+        run: yarn biome lint .

.gitignore

@@ -31,3 +31,6 @@ packages/data/scraped/
 
 # WSL
 *:Zone.Identifier
+
+# biome
+biome-logs/

.vim/coc-settings.json

@@ -0,0 +1,8 @@
+{
+  "[markdown][javascript][typescript][typescriptreact]": {
+    "coc.preferences.formatOnSave": true
+  },
+  "prettier.enable": false,
+  "eslint.enable": false,
+  "biome.enable": true
+}

biome.json

@@ -0,0 +1,26 @@
+{
+  "$schema": "https://biomejs.dev/schemas/1.4.1/schema.json",
+  "files": {
+    "ignore": [
+      "node_modules",
+      "dist",
+      ".cache",
+      "*.graphql",
+      "packages/data/scraped"
+    ],
+    "ignoreUnknown": true
+  },
+  "organizeImports": {
+    "enabled": true
+  },
+  "formatter": {
+    "enabled": true,
+    "indentStyle": "space"
+  },
+  "linter": {
+    "enabled": true,
+    "rules": {
+      "recommended": true
+    }
+  }
+}

package.json

@@ -6,11 +6,11 @@
     "build": "yarn workspaces foreach --all run build",
     "clean": "yarn workspaces foreach --all run clean",
     "distclean": "yarn workspaces foreach --all run distclean",
-    "format": "yarn workspaces foreach --all run format",
-    "lint": "yarn workspaces foreach --all run lint",
+    "format": "biome format .",
+    "lint": "biome lint .",
     "ncu": "yarn ncu-local -u; yarn workspaces foreach --all run ncu",
     "ncu-local": "ncu",
-    "prettier": "yarn workspaces foreach --all run prettier",
+    "biome-all": "yarn workspaces foreach --all run biome",
     "update": "yarn workspaces foreach --all run update",
     "github": "yarn workspace @tony/cv-scripts run github",
     "deduplicate": "npx --yes yarn-deduplicate yarn.lock"
@@ -22,9 +22,8 @@
     "packages/*"
   ],
   "devDependencies": {
-    "@ianvs/prettier-plugin-sort-imports": "^4.1.1",
-    "cross-env": "^7.0.3",
-    "oxlint": "^0.0.21"
+    "@biomejs/biome": "1.4.1",
+    "cross-env": "^7.0.3"
   },
   "packageManager": "yarn@4.0.2"
 }

packages/chart-react-billboard/package.json

@@ -9,20 +9,19 @@
     "start": "echo 'noop'",
     "build": "echo 'noop'",
     "test": "echo 'noop'",
-    "lint": "yarn oxlint",
-    "prettier": "prettier",
-    "format": "yarn run prettier . --write",
+    "lint": "yarn biome lint .",
+    "biome": "biome",
+    "format": "yarn biome format . --write",
     "update": "yarn run ncu",
     "ncu": "ncu",
     "clean": "rm -rf dist/"
   },
   "devDependencies": {
+    "@biomejs/biome": "1.4.1",
     "@types/node": "^20.10.5",
     "@types/react": "^18.2.45",
     "@types/react-dom": "^18.2.18",
     "cross-env": "^7.0.3",
-    "oxlint": "^0.0.21",
-    "prettier": "^3.1.1",
     "typescript": "^5.3.3"
   },
   "dependencies": {

packages/chart-react-billboard/src/charts.tsx

@@ -28,7 +28,7 @@ export const Chart: React.FC<bb.ChartOptions> = observer(
         setChart(newChart);
         return () => newChart.unload();
       }
-    }, [props, data]);
+    }, [props, data, setChart, chart, ref.current, data]);
 
     React.useEffect(() => {
       if (!chart || !data) {
@@ -60,17 +60,15 @@ export const LanguagePieChart: React.FC<Partial<DonutChartProps>> = observer(
             }
           },
         ),
-      [cvState],
+      [cvState, setChartData],
     );
 
     React.useEffect(() => {
       if (!chartData) {
         setChartData(stateToDonut(cvState) as DonutChartProps);
       }
       return void 0;
-    }, [cvState]);
-
-    React.useEffect(() => void 0, [chartData]);
+    }, [cvState, setChartData, chartData]);
 
     if (!chartData) {
       return null;
@@ -97,17 +95,15 @@ export const ActivityLineChart: React.FC<Partial<bb.ChartOptions>> = observer(
             }
           },
         ),
-      [cvState],
+      [cvState, setChartData],
     );
 
     React.useEffect(() => {
       if (!chartData) {
         setChartData(stateToLine(cvState) as LineChartProps);
       }
       return void 0;
-    }, [cvState]);
-
-    React.useEffect(() => void 0, [chartData]);
+    }, [setChartData, chartData, cvState]);
 
     if (!chartData) {
       return null;

packages/chart-react-billboard/src/query.ts

@@ -38,17 +38,14 @@ export const stateToDonut = (state: Instance<typeof CVState>) => {
       labels: {
         // billboard.js doesn't accept callbacks here
         // issue: https://github.com/naver/billboard.js/issues/1845
-        colors: state.languages.reduce(
-          (languageColorMap, language) => {
-            if (language) {
-              if (!(language.id in languageColorMap) && language.ui?.color) {
-                languageColorMap[language.id] = language.ui.color as string;
-              }
+        colors: state.languages.reduce((languageColorMap, language) => {
+          if (language) {
+            if (!(language.id in languageColorMap) && language.ui?.color) {
+              languageColorMap[language.id] = language.ui.color as string;
             }
-            return languageColorMap;
-          },
-          {} as { [key: string]: string },
-        ),
+          }
+          return languageColorMap;
+        }, {} as { [key: string]: string }),
       },
     },
     legend: {

packages/chart-react-carbon/package.json

@@ -9,20 +9,19 @@
     "start": "echo 'noop'",
     "build": "echo 'noop'",
     "test": "echo 'noop'",
-    "lint": "yarn oxlint",
-    "prettier": "prettier",
-    "format": "yarn run prettier . --write",
+    "lint": "yarn biome lint .",
+    "biome": "biome",
+    "format": "yarn biome format . --write",
     "update": "yarn run ncu",
     "ncu": "ncu",
     "clean": "rm -rf dist/"
   },
   "devDependencies": {
+    "@biomejs/biome": "1.4.1",
     "@types/node": "^20.10.5",
     "@types/react": "^18.2.45",
     "@types/react-dom": "^18.2.18",
     "cross-env": "^7.0.3",
-    "oxlint": "^0.0.21",
-    "prettier": "^3.1.1",
     "typescript": "^5.3.3"
   },
   "dependencies": {

packages/chart-react-carbon/src/charts.tsx

@@ -35,25 +35,21 @@ export const LanguagePieChart: React.FC<Partial<DonutChartProps>> = observer(
             }
           },
         ),
-      [cvState],
+      [cvState, setChartData],
     );
 
     React.useEffect(() => {
       if (!chartData) {
         setChartData(stateToDonut(cvState) as DonutChartProps);
       }
       return void 0;
-    }, [cvState]);
-
-    React.useEffect(() => void 0, [chartData]);
+    }, [cvState, chartData, setChartData]);
 
     if (!chartData) {
       return null;
     }
 
-    return (
-      <DonutChart ref={languageChartRef} {...chartData} {...props}></DonutChart>
-    );
+    return <DonutChart ref={languageChartRef} {...chartData} {...props} />;
   },
 );
 
@@ -75,28 +71,20 @@ export const ActivityLineChart: React.FC<Partial<LineChartProps>> = observer(
             }
           },
         ),
-      [cvState],
+      [cvState, setChartData],
     );
 
     React.useEffect(() => {
       if (!chartData) {
         setChartData(stateToLine(cvState) as LineChartProps);
       }
       return void 0;
-    }, [cvState]);
-
-    React.useEffect(() => void 0, [chartData]);
+    }, [cvState, chartData, setChartData]);
 
     if (!chartData) {
       return null;
     }
 
-    return (
-      <StackedAreaChart
-        ref={lineChartRef}
-        {...chartData}
-        {...props}
-      ></StackedAreaChart>
-    );
+    return <StackedAreaChart ref={lineChartRef} {...chartData} {...props} />;
   },
 );

packages/chart-react-nivo/package.json

@@ -9,20 +9,19 @@
     "start": "echo 'noop'",
     "build": "echo 'noop'",
     "test": "echo 'noop'",
-    "lint": "yarn oxlint",
-    "prettier": "prettier",
-    "format": "yarn run prettier . --write",
+    "lint": "yarn biome lint .",
+    "biome": "biome",
+    "format": "yarn biome format . --write",
     "update": "yarn run ncu",
     "ncu": "ncu",
     "clean": "rm -rf dist/"
   },
   "devDependencies": {
+    "@biomejs/biome": "1.4.1",
     "@types/node": "^20.10.5",
     "@types/react": "^18.2.45",
     "@types/react-dom": "^18.2.18",
     "cross-env": "^7.0.3",
-    "oxlint": "^0.0.21",
-    "prettier": "^3.1.1",
     "typescript": "^5.3.3"
   },
   "dependencies": {

packages/chart-react-nivo/src/charts.tsx

@@ -34,17 +34,15 @@ export const LanguagePieChart: React.FC<Partial<DonutChartProps>> = observer(
             }
           },
         ),
-      [cvState],
+      [cvState, setChartData],
     );
 
     React.useEffect(() => {
       if (!chartData) {
         setChartData(stateToDonut(cvState) as DonutChartProps);
       }
       return void 0;
-    }, [cvState]);
-
-    React.useEffect(() => void 0, [chartData]);
+    }, [cvState, setChartData, chartData]);
 
     if (!chartData) {
       return null;
@@ -85,17 +83,15 @@ export const ActivityLineChart: React.FC<
           }
         },
       ),
-    [cvState],
+    [cvState, setChartData],
   );
 
   React.useEffect(() => {
     if (!chartData) {
       setChartData(stateToLine(cvState) as LineChartProps);
     }
     return void 0;
-  }, [cvState]);
-
-  React.useEffect(() => void 0, [chartData]);
+  }, [cvState, chartData, setChartData]);
 
   if (!chartData) {
     return null;

packages/chart-react-nivo/src/query.ts

@@ -50,7 +50,7 @@ export const stateToDonut = (
       },
     ),
     colors: (item) => {
-      const color = state.languages.find((language) => language.id == item.id)
+      const color = state.languages.find((language) => language.id === item.id)
         ?.ui?.backgroundColor;
 
       if (color && isString(color)) {
@@ -69,7 +69,7 @@ export const stateToDonut = (
       label: string;
       value: number;
     }) => {
-      const color = state.languages.find((language) => language.id == item.id)
+      const color = state.languages.find((language) => language.id === item.id)
         ?.ui?.color;
 
       if (color && isString(color)) {

packages/chart-react-plotly/package.json

@@ -9,21 +9,20 @@
     "start": "echo 'noop'",
     "build": "echo 'noop'",
     "test": "echo 'noop'",
-    "lint": "yarn oxlint",
-    "prettier": "prettier",
-    "format": "yarn run prettier . --write",
+    "lint": "yarn biome lint .",
+    "biome": "biome",
+    "format": "yarn biome format . --write",
     "update": "yarn run ncu",
     "ncu": "ncu",
     "clean": "rm -rf dist/"
   },
   "devDependencies": {
+    "@biomejs/biome": "1.4.1",
     "@types/node": "^20.10.5",
     "@types/plotly.js": "^2.12.31",
     "@types/react": "^18.2.45",
     "@types/react-dom": "^18.2.18",
     "cross-env": "^7.0.3",
-    "oxlint": "^0.0.21",
-    "prettier": "^3.1.1",
     "typescript": "^5.3.3"
   },
   "dependencies": {