Have a command that toggles throw ball with mouse on #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using a getter, `pets` on `allPets` can be accessed using `.pets` rather than needing to call it as a method (`.pets()`)
For pet type class methods that just return private values, replace the methods with getter methods so that the fields can be accessed on the pets without parentheses. E.g. `pet.name` instead of `pet.name()`
Add new duck names
Change PetCollection.pets to be a getter
Change relevant pet fields to getters
Added new pet names
Add pet names
…ation Avoid `*` activating extension
I have added a few new pet names of snake, duck, and crab.
Updated name.ts
adding white cat option
Codecov Report
@@ Coverage Diff @@
## master #376 +/- ##
==========================================
- Coverage 17.08% 16.99% -0.09%
==========================================
Files 21 21
Lines 1147 1153 +6
Branches 154 156 +2
==========================================
Hits 196 196
- Misses 942 951 +9
+ Partials 9 6 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Harry-Hopkinson
changed the title
New Crowdin translations
Add pet size small
tonybaloney
reviewed
Feb 9, 2023
package.json
Outdated
| @@ -84,7 +84,7 @@ | |||
| "icon": "media/dog.svg" | |||
| }, | |||
| { | |||
| "command": "vscode-pets.throw-with-mouse", | |||
| "command": "vscode-pets.throwBallWithMouse", | |||
There was a problem hiding this comment.
Why did you change the command ID to camelCase?
There was a problem hiding this comment.
Sorry it had the same name as a variable in extension.ts so I presumed that it had to be named the same.
Gitignore build file and DS_Store
|
I have had to force a bunch of changes to this repository to remove the cat assets (and previous copies). GitHub automatically closed the PR. You may need to create a new fork, before submitting future changes. |
rlszabo
added a commit
to rlszabo/vscode-pets
that referenced
this pull request
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Throw ball with mouse" command that toggles the throw ball with mouse option on or off. For #375