Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for SvelteKit, better abstractions for Sapper #34

Closed
tonyketcham opened this issue Apr 28, 2021 · 2 comments
Closed

Support for SvelteKit, better abstractions for Sapper #34

tonyketcham opened this issue Apr 28, 2021 · 2 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@tonyketcham
Copy link
Owner

tonyketcham commented Apr 28, 2021

The Problem

Using this component in SvelteKit & Sapper is incredibly verbose and negates the core point of this component - to abstract away the complexity of mounting p5 to a Svelte project. This component should be functionally hot-swappable between SvelteKit, Sapper, etc. with no special user config required.

The Fix

The user should have an elegantly simple way to drop p5-svelte into any Svelte project. The API needs to be consistent as well as expanded to optionally allow direct access to the p5 instance running under the hood. The installation method needs to be redone to be universally adaptable while increasing both functionality and simplicity without introducing breaking changes.

@tonyketcham tonyketcham added bug Something isn't working enhancement New feature or request labels Apr 28, 2021
@tonyketcham tonyketcham self-assigned this Apr 28, 2021
@Lakedaemon
Copy link

Did you manage to make it work for sveltekit ?
I would really like to use p5 in my sveltekit spas

@tonyketcham tonyketcham added this to the v3 milestone Aug 29, 2021
@tonyketcham
Copy link
Owner Author

@Lakedaemon it took me a while to get around to it but yes!

Resolved in v3.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants