Unify window style #380
Merged
Unify window style #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some funky :not being used to resolve .tb-window-tabs from .tb-popup-tabs, but in a moment I'll be unifying these two into one normal block of code and it'll all be good again
Venefilyn
reviewed
Oct 4, 2020
creesch
reviewed
Oct 19, 2020
|
Latest commit fixes that issue for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unifies the
.tb-window-*,.tb-popup-*, and.tb-notification-*classes under a single.tb-window-*scheme including modifier classes. Also adds an argument toTBui.overlayto control the tab bar orientation, to make the profile overlay less of a special case, and adds documentation to the arguments of that function. The overlay CSS was also modified to not rely on containing a specific type of window in case that's desirable in the future (thoughTBui.overlaystill generates large static windows and nothing else).TBui.popup()returns a.tb-window.tb-window-draggableTBui.overlay()uses a.tb-window.tb-window-large.tb-window-vertical-tabsTBui.showNotification()uses a basic.tb-windowTechnically, there are still slight differences in the markup generated by
TBui.popupandTBui.overlay, but those differences are mostly in how data for multiple tabs is stored. This PR is only concerned with unifying the classes controlling visual appearance; a future PR can handle unifying the internal structure, since that will probably require breaking out a dedicated tabber component and retrofitting it into the existing UI generators.Supercedes #327. Fixes #240.