Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usernotes manager buttons not working #426

Merged
merged 2 commits into from Dec 10, 2020
Merged

Conversation

eritbh
Copy link
Member

@eritbh eritbh commented Dec 9, 2020

Close button not working probably caused by #380. We really need a helper for these guys, so much different markup everywhere...

Other buttons not working probably an oversight from #223, which is... very old by now. Maybe #380 had a hand in it too, not sure how else this bug would've lasted that long.

@eritbh eritbh added bug something isn't working module: usernotes labels Dec 9, 2020
@eritbh eritbh added this to the v5.5 milestone Dec 9, 2020
@eritbh eritbh changed the title Fix selector for usernotes manager close button Fix usernotes manager buttons not working Dec 9, 2020
@creesch
Copy link
Member

creesch commented Dec 10, 2020

Other buttons not working probably an oversight from #223, which is... very old by now. Maybe #380 had a hand in it too, not sure how else this bug would've lasted that long.

Probably because we haven't had a release in a while and this code isn't live yet? We probably should work towards releasing our current code.

@creesch creesch merged commit c02116a into master Dec 10, 2020
@creesch creesch deleted the fix-un-close-button branch December 10, 2020 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working module: usernotes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants