Exempt initial requests from ratelimits #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eritbh
added a commit
that referenced
this pull request
Sep 5, 2024
* Add support for bypassing ratelimits * Store pending requests as objects for clarity * Add types to the rest of these props for fun * Use bypassRatelimit for initial info requests * bypassLimit is in the request options, derp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially fixes an issue where Toolbox would intermittently not load when a page is first loaded.
Adds an additional argument to
Ratelimiter#request, an options object which influences how the ratelimiter processes the request. The only current option isbypassLimit, which causes the request to be sent immediately when it is added to the queue, without checking if the current bucket still has requests remaining. This option is passed byTBApi.getJSONasbypassRatelimitand is used exclusively by the requests made when Toolbox is first loading in order to prevent them from blocking all of Toolbox.Also includes some light restructuring of the Ratelimiter class - added type annotations to its properties and switched to storing pending requests as objects rather than array. Also added typedefs for the relevant interfaces.
The ESLint
ecmaVersionbump is compatible with all our supported browsers and allows for the...spread notation for object properties, which is used here.