Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

[BUG] Editing alt text: "edit failed" dialog has no "Cancel option #548

Closed
ingernet opened this issue Dec 10, 2022 · 7 comments
Closed

[BUG] Editing alt text: "edit failed" dialog has no "Cancel option #548

ingernet opened this issue Dec 10, 2022 · 7 comments
Assignees
Labels

Comments

@ingernet
Copy link

Mastodon in general has an issue surrounding editing alt text of an existing toot. The server code has an pending PR, but that doesn't solve this iOS UI issue in the Tooot app. After I've tried, unsuccessfully, to edit some alt text, I get an "Editing failed" dialog, with only one option: "Try again."

While I admire the optimism of this design, I believe that a "Cancel" option would be a prudent addition here. As it is, I have to force quit the app to get out of that dialog.

IMG_1946

IMG_1947

@ingernet
Copy link
Author

BTW this is on 4.6.6.

@xmflsct xmflsct self-assigned this Dec 10, 2022
@xmflsct xmflsct added the bug label Dec 10, 2022
@xmflsct
Copy link
Member

xmflsct commented Dec 10, 2022

Interesting, did not even test re-edit a media's alt text. Assuming that should work out of the box.

I will get a PR to disallow editing media details when editing a toot. Though you can already "exit" the modal, by tapping on the chevron icon on the top left corner.

@ingernet
Copy link
Author

@xmflsct thanks for your response! Alas, once you have clicked the "Save"icon, the chevron is not active. You are stuck interacting with the dialog.

@xmflsct
Copy link
Member

xmflsct commented Dec 10, 2022

@ingernet then that chevron might be a bug yeah

@ingernet
Copy link
Author

@xmflsct so...should we reopen this ticket, then? Seems like every interaction that would result in a POST should have a "back out/cancel" option, yes? Seems like the chevron is doing what it's supposed to do, if you can get to it.

@xmflsct
Copy link
Member

xmflsct commented Dec 10, 2022

Just tested again locally, tapping on the chevron can always dismiss the modal. Maybe it was an issue but now I also re-arranged the code a bit while fixing the issue you mentioned.

<HeaderLeft type='icon' content='ChevronDown' onPress={() => navigation.goBack()} />
In principle the action should just work, there is no condition attached to it.

@ingernet
Copy link
Author

ingernet commented Dec 10, 2022 via email

@xmflsct xmflsct mentioned this issue Jan 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants