Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relaxed body and empty message doesn't validate #9

Open
wingedpig opened this issue Aug 15, 2018 · 0 comments
Open

Relaxed body and empty message doesn't validate #9

wingedpig opened this issue Aug 15, 2018 · 0 comments
Assignees

Comments

@wingedpig
Copy link

Best I can tell from reading the RFC and your code, you're processing relaxed bodies correctly. But I have verified with three different services, including Gmail and Yahoo Mail, that messages sent by them with empty bodies do not verify. The fix is easy (I don't have a PR because I've modified the code a bunch for other reasons). In dkim.go, line 361, wrap that append line with a "if len(body) > 0" conditional.

It's easy to test. In Gmail, send yourself a blank message. Then validate its DKIM sig.

@toorop toorop self-assigned this Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants