Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in electron 3.0.0 #111

Open
dganzella opened this issue Sep 11, 2018 · 5 comments
Open

Error in electron 3.0.0 #111

dganzella opened this issue Sep 11, 2018 · 5 comments

Comments

@dganzella
Copy link

screen shot 2018-09-11 at 16 33 24

I think the binding.node needs to be rebuilt with newer node module version.

Any hints on how to do it?

@dganzella
Copy link
Author

It seems the issue is on the https://github.com/TooTallNate/ref .

@dganzella
Copy link
Author

To fix this issue, I had to do this:

Forked this repo, removed ffi and ref from dependencies of nodobjc.

https://github.com/dganzella/NodObjC.git

And added my rep, ref and ffi direct from the most updated versions

"nodobjc": "git+https://github.com/dganzella/NodObjC.git",
"ref": "git+https://github.com/TooTallNate/ref",
"ffi": "git+https://github.com/node-ffi/node-ffi"

Then installed electron-rebuild and ran it.

ps. For some reason, adding the latest versions of ref and ffi directly as dependencies of my nodobjc fork didnt work.

@cworsley4
Copy link

Huge help @dganzella thank you! Do NOT discount the necessity of the electron-rebuild module. Must be done.

@briangonzalez
Copy link

Thanks @dganzella! Those deps could be more succinctly written as:

{
  "nodobjc": "dganzella/NodObjC",
  "ref": "TooTallNate/ref",
  "ffi": "node-ffi/node-ffi"
}

aguynamedben added a commit to getcommande/NodObjC that referenced this issue Oct 16, 2019
Following the instructions listed here:
TooTallNate#111 (comment)

Then will use the branches listed here:
node-ffi/node-ffi#544
@harshitsilly
Copy link

have someone tried this with electron v7.. for me i am getting error on make

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants