-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error in electron 3.0.0 #111
Comments
It seems the issue is on the https://github.com/TooTallNate/ref . |
To fix this issue, I had to do this: Forked this repo, removed ffi and ref from dependencies of nodobjc. https://github.com/dganzella/NodObjC.git And added my rep, ref and ffi direct from the most updated versions
Then installed electron-rebuild and ran it. ps. For some reason, adding the latest versions of ref and ffi directly as dependencies of my nodobjc fork didnt work. |
Huge help @dganzella thank you! Do NOT discount the necessity of the electron-rebuild module. Must be done. |
Thanks @dganzella! Those deps could be more succinctly written as: {
"nodobjc": "dganzella/NodObjC",
"ref": "TooTallNate/ref",
"ffi": "node-ffi/node-ffi"
} |
Following the instructions listed here: TooTallNate#111 (comment) Then will use the branches listed here: node-ffi/node-ffi#544
have someone tried this with electron v7.. for me i am getting error on make |
I think the binding.node needs to be rebuilt with newer node module version.
Any hints on how to do it?
The text was updated successfully, but these errors were encountered: