Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

result === undefined #47

Closed
2fours opened this issue Apr 25, 2014 · 1 comment · Fixed by #48
Closed

result === undefined #47

2fours opened this issue Apr 25, 2014 · 1 comment · Fixed by #48

Comments

@2fours
Copy link
Contributor

2fours commented Apr 25, 2014

I'm looking at the check on line 109 of sender.js:

https://github.com/ToothlessGear/node-gcm/blob/master/lib/sender.js#L109

and I'm wondering how it ever retries as sendNoRetry always calls the callback with result of null when an error occurs. The check then becomes if (null === undefined) which evaluates to false. Should it not just be if (result == undefined) or (result == null) or just if (!result)?

@2fours
Copy link
Contributor Author

2fours commented Apr 25, 2014

Looks like this commit broke it: 4afa976.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant