Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hashtag column not subscribing to stream on mount #10040

Merged
merged 1 commit into from Feb 14, 2019

Conversation

Projects
None yet
2 participants
@Gargron
Copy link
Member

Gargron commented Feb 14, 2019

Fix #9895

@Gargron Gargron added the bug label Feb 14, 2019

@mayaeh

This comment has been minimized.

Copy link
Collaborator

mayaeh commented Feb 14, 2019

I tried this on my test server and it seemed to be fine.
Thank you 🙏

@mayaeh

This comment has been minimized.

Copy link
Collaborator

mayaeh commented Feb 14, 2019

However after a while the disconnected mark (...) was displayed at hashtag column, so I check back for a while.

edit:
It seems that a disconnected mark "..." appears when pinning a new hashtag column or unpinning it.
I confirmed this with Firefox for mac and Chrome for mac, but no errors were displayed on the browser side.

@mayaeh

This comment has been minimized.

Copy link
Collaborator

mayaeh commented Feb 14, 2019

It seems that a disconnected mark "..."

Sorry for the ambiguous expression.
It is "load-more" "load-gap" class's button.

And even though this is displayed the column has been updated.
The streaming connection seems to be continuing.

@mayaeh

mayaeh approved these changes Feb 14, 2019

Copy link
Collaborator

mayaeh left a comment

#9895 's problem seems to be solved by this, and I don't see errors in particular, so I approve this.

@Gargron Gargron merged commit aa83219 into master Feb 14, 2019

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

@ykzts ykzts deleted the fix-hashtag-column-streaming branch Feb 15, 2019

ThibG added a commit to ThibG/mastodon that referenced this pull request Feb 17, 2019

ThibG added a commit to glitch-soc/mastodon that referenced this pull request Feb 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.