Home from db after limit #5679
Home from db after limit #5679
Conversation
ClearlyClaire
added
the
work in progress
ClearlyClaire
force-pushed
the
home-from-db-after-limit
branch
4 times, most recently
from
f841aab
to
1e12659
Compare
|
I currently have no idea what's going on with the failing tests, to be honest. |
app/models/feed.rb
Outdated
| Status.as_home_timeline(@account) | ||
| .paginate_by_max_id(limit, max_id, since_id) | ||
| .reject { |status| FeedManager.instance.filter?(:home, status, @account.id) } | ||
| for attempt in 0..20 do |
There was a problem hiding this comment.
for attempt in 0..20 do -> 21.times do
There was a problem hiding this comment.
Right, thanks! This commit is not needed, though, I just tried to avoid the test failures, but I still don't understand it. I will drop that commit.
ClearlyClaire
force-pushed
the
home-from-db-after-limit
branch
3 times, most recently
from
84d37bf
to
d8610db
Compare
|
Fixed the test (since it now passes). This is still sub-optimal as it may return less statuses than requested while performing potentially useless SQL queries, but it works. |
ClearlyClaire
removed
the
work in progress
|
Removed the “work in progress” label as I'm probably not going to work on the SQL side of things. |
ClearlyClaire
force-pushed
the
home-from-db-after-limit
branch
from
d8610db
to
173e464
Compare
|
Duplicate of #4016? |
|
@akihikodaki yes, indeed, gonna close this one, but you want to fix |
This change allows to scroll back past the 400 toots limit of the Redis cache for the Home Timeline.
Indeed, some users like to read all the toots from their timeline, but may be away long enough for it to exceed the 400 toots limit.
This PR is tagged as work in progress as it may be greatly inefficient---although that only affects people actually scrolling past those 400 toots or waiting for the cache to be repopulated.
I guess it would be ideal to move the various filters to the SQL query in
Status#as_home_timeline.