Profile redirect notes #5746

Gargron · 2017-11-18T03:23:27Z

See also #177 (partial)

Database structure to store information about where account moved
Serialize this information in REST API and ActivityPub
Deserialize this information from ActivityPub
Display note on public profiles
Display note on profiles in web UI

Please mind that this PR does not include the automatic followers unfollow/re-follow of new account, nor does it include a way to actually set this "move" information, yet. Therefore, it's only one step towards solving #177

ClearlyClaire · 2017-11-18T08:33:53Z

app/lib/activitypub/adapter.rb

@@ -9,6 +9,7 @@ class ActivityPub::Adapter < ActiveModelSerializers::Adapter::Base
      {
        'manuallyApprovesFollowers' => 'as:manuallyApprovesFollowers',
        'sensitive'                 => 'as:sensitive',
+        'movedTo'                   => 'as:movedTo',


Should you really use ActivityStreams' namespace for that? I couldn't find any documentation for “movedTo”

I made it up since it doesn't exist, but probably should exist. @cwebber is okay with it

Alright, that's fine with me.

ClearlyClaire · 2017-11-18T15:10:53Z

I'm wondering if it would make sense to redirect webfinger queries, too.

Gargron · 2017-11-18T15:14:57Z

@ThibG

Gargron - Yesterday at 9:56 PM
@nightpool i just implemented a webfinger redirect for accounts and getting second thoughts. maybe the only redirect should be the public profile page. because a webfinger redirect would brick any look-up of all old content... plus it's a rabbit hole, there's a ton of ActivityPub endpoints, it's unclear whether you should be able to redirect them and them still be considered valid, and there's no way to tell if the new server has the same ActivityPub URI structure, etc. and so that would also brick stuff. redirecting public profile page and adding a "redirects" to the REST API so apps can show a special note, maybe that's all
nightpool - Yesterday at 10:01 PM
hm.
I don't see how redirecting the webfinger will break lookup of old content?
Gargron - Yesterday at 10:04 PM
it's all very confusing but say I am looking up "Hello world" by Gargron@mastodon.social, but Gargron@mastodon.social redirects to gargron@gonext.gg. Let's say we modified our webfinger code to even follow redirects in the first place. Now it creates "Hello world" as created by gargron@gonext.gg. You favourite it. That activity is sent to gargron@gonext.gg... but that post does not exist there, so it blackholes
That's just one example
nightpool - Yesterday at 10:04 PM
How are you looking up that post, by URI?
Gargron - Yesterday at 10:05 PM
Webfinger code not supporting redirects in all versions is even bigger. It'll just mean the content will not be processed in the first place.
nightpool - Yesterday at 10:05 PM
It should still have mastodon.social/users/gargron as the post actor
yeah the redirect is maybe a bigger concern.....
Gargron - Yesterday at 10:05 PM
It doesn't matter how you look up the post, when it checks the author it does webfinger.
nightpool - Yesterday at 10:07 PM
I don't think that's true
FetchRemoteStatusService uses attributedTo.
Gargron - Yesterday at 10:10 PM
when mastodon looks up an activitypub actor for the first time, i.e. there's no existing db record, it performs a webfinger verification
which leads to the scenario i described
there's also the question of... what if the record exists, but then webfinger cache is stale so we webfinger again, and it redirects. wtf do then
nightpool - Yesterday at 10:11 PM
Sure, okay
Gargron - Yesterday at 10:12 PM
thinking about all the ways in which this sort of thing can fuck up things is making my brain hurt

ClearlyClaire · 2017-11-18T15:28:06Z

@Gargron yeah, indeed, that's what I was thinking. Since the content is still there, it kind of makes sense to not stop it from federating. The advantage is that it would be completely transparent to whichever software, OStatus or ActivityPub, supporting “movedTo” or not. The downside is that it would stop the content of the old profile from federating anymore, although it's still there… it's probably not worth it, I guess.

ClearlyClaire · 2017-11-18T16:25:55Z

Another thing I'm wondering about and you haven't brought up in this PR is make every follower of the old account automatically send a follow request to the new one (and potentially unfollow the old one) once it's discovered to have moved.

Gargron · 2017-11-18T16:53:34Z

@ThibG No that's not at all included in this PR.

ClearlyClaire · 2017-11-18T16:59:55Z

Yes, I know, I was simply wondering if doing that would make sense.

ClearlyClaire

I'm not very familiar with React.js, but everything else looks fine to me.

ClearlyClaire · 2017-11-18T18:21:12Z

app/javascript/mastodon/features/account_timeline/components/moved_note.js

+      <div className='account__moved-note'>
+        <div className='account__moved-note__message'>
+          <div className='account__moved-note__icon-wrapper'><i className='fa fa-fw fa-suitcase account__moved-note__icon' /></div>
+          <FormattedMessage id='account.moved_to' defaultMessage='{name} has moved to:' values={{ name: <strong dangerouslySetInnerHTML={displayNameHtml} /> }} />


Wouldn't it better if the name was a link to the new account?

That's the old name

* yarn manage:translations * Add Japanese translation for #5087 * Add Japanese translation for #5616 * Add Japanese translation for #5746 * Add Japanese translation for #5750

* Serialize moved accounts into REST and ActivityPub APIs * Parse federated moved accounts from ActivityPub * Add note about moved accounts to public profiles * Add moved account message to web UI * Fix code style issues

…todon#5764)

* yarn manage:translations * Add Japanese translation for mastodon#5087 * Add Japanese translation for mastodon#5616 * Add Japanese translation for mastodon#5746 * Add Japanese translation for mastodon#5750

…todon#5816)

Cam-B · 2017-12-14T15:17:30Z

One step further. Awesome!

Gargron added 3 commits November 18, 2017 02:46

Serialize moved accounts into REST and ActivityPub APIs

447b974

Parse federated moved accounts from ActivityPub

8f39f8e

Add note about moved accounts to public profiles

24ca44e

Gargron added activitypub Protocol-related changes, federation work in progress Not to be merged, currently being worked on labels Nov 18, 2017

ClearlyClaire reviewed Nov 18, 2017

View reviewed changes

Gargron added 2 commits November 18, 2017 18:30

Add moved account message to web UI

0925649

Fix code style issues

1a6feab

Gargron removed the work in progress Not to be merged, currently being worked on label Nov 18, 2017

ClearlyClaire approved these changes Nov 18, 2017

View reviewed changes

Gargron merged commit 58cede4 into master Nov 18, 2017

mayaeh mentioned this pull request Nov 21, 2017

i18n: Update ja translations #5769

Merged

Gargron pushed a commit that referenced this pull request Nov 23, 2017

i18n: (zh-CN) Add translations for #5746 & #5735 (#5764)

bc4a726

ykzts mentioned this pull request Nov 25, 2017

Add Japanese translations #5810

Merged

Gargron pushed a commit that referenced this pull request Nov 25, 2017

Add Japanese translations (#5810)

520d147

* yarn manage:translations * Add Japanese translation for #5087 * Add Japanese translation for #5616 * Add Japanese translation for #5746 * Add Japanese translation for #5750

ykzts pushed a commit that referenced this pull request Nov 25, 2017

i18n: (zh-CN) Add translations for #5746 & #5750 (#5816)

57fe410

This was referenced Nov 27, 2017

Add UI for setting up account migration #5832

Merged

Bump version to 2.1.0rc1 #5834

Merged

cobodo pushed a commit to cobodo/mastodon that referenced this pull request Dec 6, 2017

i18n: (zh-CN) Add translations for mastodon#5746 & mastodon#5735 (mas…

06d5016

…todon#5764)

cobodo pushed a commit to cobodo/mastodon that referenced this pull request Dec 6, 2017

i18n: (zh-CN) Add translations for mastodon#5746 & mastodon#5750 (mas…

756e39b

…todon#5816)

gjorando mentioned this pull request Dec 15, 2017

Autoreply #5944

Closed

2 tasks

trwnh mentioned this pull request Dec 19, 2017

Support account migration #177

Closed

iandioch mentioned this pull request Oct 17, 2018

Allow users to change username CPSSD/rabble#87

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Profile redirect notes #5746

Profile redirect notes #5746

Gargron commented Nov 18, 2017 •

edited

Loading

ClearlyClaire Nov 18, 2017

Gargron Nov 18, 2017

ClearlyClaire Nov 18, 2017

ClearlyClaire commented Nov 18, 2017

Gargron commented Nov 18, 2017

ClearlyClaire commented Nov 18, 2017

ClearlyClaire commented Nov 18, 2017

Gargron commented Nov 18, 2017

ClearlyClaire commented Nov 18, 2017 via email

ClearlyClaire left a comment

ClearlyClaire Nov 18, 2017

Gargron Nov 18, 2017

Cam-B commented Dec 14, 2017

Profile redirect notes #5746

Profile redirect notes #5746

Conversation

Gargron commented Nov 18, 2017 • edited Loading

ClearlyClaire Nov 18, 2017

Choose a reason for hiding this comment

Gargron Nov 18, 2017

Choose a reason for hiding this comment

ClearlyClaire Nov 18, 2017

Choose a reason for hiding this comment

ClearlyClaire commented Nov 18, 2017

Gargron commented Nov 18, 2017

ClearlyClaire commented Nov 18, 2017

ClearlyClaire commented Nov 18, 2017

Gargron commented Nov 18, 2017

ClearlyClaire commented Nov 18, 2017 via email

ClearlyClaire left a comment

Choose a reason for hiding this comment

ClearlyClaire Nov 18, 2017

Choose a reason for hiding this comment

Gargron Nov 18, 2017

Choose a reason for hiding this comment

Cam-B commented Dec 14, 2017

Gargron commented Nov 18, 2017 •

edited

Loading