Cancel outdated pending compose suggestions #6838
Conversation
|
I don't get it, how do you decide what is obsolete or not? |
|
@LienRag the most recently-issued request is the only one which results we are interested in. Any other request that might still be running can be canceled. |
|
Hm, some unexpected behavior is still going on, and I'm not completely sure why: when typing something that could be a username (e.g. |
| @@ -11,6 +12,9 @@ import { | |||
| refreshPublicTimeline, | |||
| } from './timelines'; | |||
|
|
|||
| var CancelToken = axios.CancelToken; | |||
| api(getState).get('/api/v1/accounts/search', { | ||
| cancelToken: new CancelToken(function (cancel) { |
ClearlyClaire
force-pushed
the
fixes/cancel-compose-suggest-queries
branch
from
91ca509
to
7070f52
Compare
| @@ -11,6 +12,9 @@ import { | |||
| refreshPublicTimeline, | |||
| } from './timelines'; | |||
|
|
|||
| let CancelToken = axios.CancelToken; | |||
| let _CancelFetchComposeSuggestionsAccounts; | |||
There was a problem hiding this comment.
What is this underscore?
There was a problem hiding this comment.
Just a sign that this is to remain private to this module. But this convention doesn't appear to be used widely/consistently within Mastodon, so I guess I can drop it (and also start with a lowercase).
There was a problem hiding this comment.
I'm for dropping this because the code knows it, even without such a symbol. The code will not allow to use the variable out of this module.
If i recall correctly, underscore as prefix is seen in some components of Mastodon, but that could make sense because the code doesn't know a variable is private, and allows to use it out of the component (if ref is there.)
ClearlyClaire
force-pushed
the
fixes/cancel-compose-suggest-queries
branch
from
7070f52
to
b5d1ebe
Compare
| @@ -1,4 +1,5 @@ | |||
| import api from '../api'; | |||
| import axios from 'axios'; | |||
There was a problem hiding this comment.
Oh I get it now
import axios, { CancelToken } from 'axios';
should work instead of let CancelToken
ClearlyClaire
force-pushed
the
fixes/cancel-compose-suggest-queries
branch
from
b5d1ebe
to
7546095
Compare
ClearlyClaire
force-pushed
the
fixes/cancel-compose-suggest-queries
branch
from
7546095
to
08f49bd
Compare
This PR cancels outdated compose suggestions requests to prevent outdated results to show up instead of newer (usually more precise) ones, or when the current composed text does not call for a completion.