Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link color in high-contrast theme, add underlines #9949

Merged
merged 1 commit into from Jan 31, 2019

Conversation

Projects
None yet
2 participants
@Gargron
Copy link
Member

Gargron commented Jan 30, 2019

Improve sorting of default themes in the dropdown

image

Fix link color in high-contrast theme, add underlines
Improve sorting of default themes in the dropdown
@ashleyhull-versent

This comment has been minimized.

Copy link
Contributor

ashleyhull-versent commented Jan 31, 2019

Could we investigate the idea of having underlines for external links only? the link to internal user/hashtag/show thread doesn't need an underline.

@Gargron

This comment has been minimized.

Copy link
Member Author

Gargron commented Jan 31, 2019

What I've encountered in practice is that the classes used by Pleroma/Pixelfed/Misskey and others don't quite match up, so either I make all links look as similar as possible, or it's gonna be really jarring when you see a non-Mastodon post, which I would prefer to avoid.

@Gargron Gargron merged commit ad8c71c into master Jan 31, 2019

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

@Gargron Gargron deleted the fix-high-contrast-links branch Jan 31, 2019

ThibG added a commit to ThibG/mastodon that referenced this pull request Feb 1, 2019

Fix link color in high-contrast theme, add underlines (tootsuite#9949)
Improve sorting of default themes in the dropdown

masanbol added a commit to masanbol/snoutsonline that referenced this pull request Feb 3, 2019

Gargron added a commit that referenced this pull request Feb 17, 2019

Fix link color in high-contrast theme, add underlines (#9949)
Improve sorting of default themes in the dropdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.