New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errno::ECHILD thrown from Process.waitpid, some Process methods #732
Merged
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9e09586
WIP: Errno::ECHILD thrown from Process.waitpid
jstepien 10d8280
Let's untag one of specs and see what happens!
jstepien c0c85a3
Errno::* are subclasses of SystemCallError
jstepien f637bfd
Add an Errno generator, move some code out of try
jstepien 4b4a3fa
Merge remote-tracking branch 'origin/master' into errno-echild
jstepien dcfa50a
Process#{wait,wait2,waitall}
jstepien 7d78641
Merge error_for_oserror and errno_for_oserror
jstepien 5bd31a2
Minimise the try block in error_for_oserror
jstepien File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
module Errno | ||
class ECHILD < Exception | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,8 @@ | |
|
||
from topaz.module import ModuleDef | ||
from topaz.system import IS_WINDOWS | ||
from topaz.objects.classobject import W_ClassObject | ||
from topaz.objects.moduleobject import W_ModuleObject | ||
|
||
|
||
if IS_WINDOWS: | ||
|
@@ -35,15 +37,21 @@ def method_pid(self, space): | |
|
||
@moduledef.function("waitpid", pid="int") | ||
def method_waitpid(self, space, pid=-1): | ||
pid, status = os.waitpid(pid, 0) | ||
status = WEXITSTATUS(status) | ||
w_status = space.send( | ||
space.find_const(self, "Status"), | ||
"new", | ||
[space.newint(pid), space.newint(status)] | ||
) | ||
space.globals.set(space, "$?", w_status) | ||
return space.newint(pid) | ||
try: | ||
pid, status = os.waitpid(pid, 0) | ||
status = WEXITSTATUS(status) | ||
w_status = space.send( | ||
space.find_const(self, "Status"), | ||
"new", | ||
[space.newint(pid), space.newint(status)] | ||
) | ||
space.globals.set(space, "$?", w_status) | ||
return space.newint(pid) | ||
except OSError as ex: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Only the minim amount of code should be inside of the |
||
errno = space.find_const(self, "Errno") | ||
echild = space.find_const(errno, "ECHILD") | ||
assert isinstance(echild, W_ClassObject) | ||
raise space.error(echild, str(ex)) | ||
|
||
@moduledef.function("exit", status="int") | ||
def method_exit(self, space, status=0): | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This inherits
SystemCallError
as far as I can tell.