Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort Submissions Columns #3427

Closed
codeMinter opened this issue Oct 30, 2019 · 28 comments
Closed

Sort Submissions Columns #3427

codeMinter opened this issue Oct 30, 2019 · 28 comments
Assignees
Labels

Comments

@codeMinter
Copy link
Contributor

https://www.topcoder.com/challenges/30104447/?type=develop

@codeMinter codeMinter self-assigned this Oct 30, 2019
@codeMinter
Copy link
Contributor Author

@Oanh-and-only-Oanh added this ticket to track Submissions page sorting changes.

@sushilshinde FYI ☝️

@Oanh-and-only-Oanh
Copy link
Collaborator

"countryname/flag" is out of scope of now.
FYI @codeMinter @nithyaasworld

@codeMinter
Copy link
Contributor Author

@nithyaasworld can you help test this on DEV ?

@nithyaasworld
Copy link
Collaborator

@codeMinter Please find the results below:

  1. MM Results are not shown in Beta.
    image

  2. I think we should not show the Rating column for the Design Challenges as they don't have rating. Please correct me if I am wrong. Thanks.
    image

  3. I guess Rating is not applicable to F2F challenges too. Please confirm.
    image

  4. In Design challenges' Submission tab, info text is going out of the frame. Please check the screenshot below:

image

@nithyaasworld nithyaasworld added the QA Fail QA verification on Dev has failed. Assignee to redo the fix. label Oct 31, 2019
@codeMinter
Copy link
Contributor Author

codeMinter commented Oct 31, 2019

Thanks @nithyaasworld

  1. MM Results are not shown in Beta

I know the problem, bcos this deployment was done from branch, which doesn't still has the code from master. This will go once we merge, let me do that and push new release to beta tomm

  1. I think we should not show the Rating column for the Design Challenges as they don't have rating. Please correct me if I am wrong. Thanks.

Yes, you are right here, while you were working on testing, I was fixing this as realised Design doesn't has ratings.

  1. I guess Rating is not applicable to F2F challenges too. Please confirm.

yup you are right we will not get rating for F2F too, will take this off too.

  1. In Design challenges' Submission tab, info text is going out of the frame. Please check the screenshot below:

will look at this and push along with fix for 1 above.

I will flag you once this is pushed to dev/beta for testing.

@codeMinter
Copy link
Contributor Author

FYI - @nithyaasworld everything except 1 is on beta now. I will flag once we have 1 on beta, tracing what is causing it as we already synced and deployed the latest code now.

@nithyaasworld
Copy link
Collaborator

Ok, I will wait for 1 and test them all together

@Oanh-and-only-Oanh Oanh-and-only-Oanh removed the QA Fail QA verification on Dev has failed. Assignee to redo the fix. label Nov 1, 2019
@nithyaasworld
Copy link
Collaborator

@codeMinter is No:1 ready for testing?

@codeMinter
Copy link
Contributor Author

@nithyaasworld not yet, we are still sorting the branch conflicts, will update as soon as ready.

@codeMinter
Copy link
Contributor Author

@nithyaasworld this is on test and beta, please help test.

@codeMinter
Copy link
Contributor Author

@nithyaasworld this is on beta, please help test.

@nithyaasworld
Copy link
Collaborator

nithyaasworld commented Nov 18, 2019

@codeMinter

Minor issue: When accessing the Challenges page, the Registrants are expected to be sorted based on the Registration date. But in beta, it is not sorted in ascending, by default. Whereas in Production, registrants are sorted based on registration date by default. Please check the challenge: https://beta-community-app.topcoder.com/challenges/30106903?tab=registrants

image

@codeMinter
Copy link
Contributor Author

codeMinter commented Nov 18, 2019

@nithyaasworld doesn't look like you applied sorting - once you apply sorting you should see color of arrow for Registration Date as blue highlighted which I don't see in your shared snapshot above.

@nithyaasworld
Copy link
Collaborator

You are right! I just updated my above comment with more details. Please check.

@codeMinter
Copy link
Contributor Author

@Oanh-and-only-Oanh @nithyaasworld Since Design and F2F wouldn't have Rating, I have swapped default sort to be by Registration Date like we have currently in PROD.

@nithyaasworld
Copy link
Collaborator

I think we need to remove the Rating column for Bug Hunt too as its not a rated competition.

Apart from this and the default registration sorting issue, there are no other issues.

image

@codeMinter
Copy link
Contributor Author

@nithyaasworld ☝️ has been addressed too. Kindly test on beta once you are ready.

@Oanh-and-only-Oanh @nithyaasworld FYI, note below change:

  1. Registrations sorting now happens on Registration Date.
  2. Submissions sorting now happens on Submitted Date. For MM, it is based on Provisional and Final score.

So this way we will have default sorting in sync for all kind of challenges.

@nithyaasworld
Copy link
Collaborator

@codeMinter Sorting in the MM Leaderboard is not working. I think I missed to check this when checking for every other tracks. I should have checked this first. Sorry about this!

image

@Oanh-and-only-Oanh
Copy link
Collaborator

@codeMinter, was only able to replicate the issue @nithyaasworld mentioned above using incognito mode.

@codeMinter
Copy link
Contributor Author

@Oanh-and-only-Oanh have pushed in fix, @nithyaasworld is helping test this once more. I did some code formatting for previous issue which caused this issue. It worked for you bcos of browser cache. Let @nithyaasworld confirm and will work with @sushilshinde in morning to get this merged and pushed for smoke testing after which we can move this to PROD tomm likely 🤞

@nithyaasworld
Copy link
Collaborator

@codeMinter
Issue:1-> For the below challenge, Provisional ranks 74, 75 are displayed at the last
image

Issue:2-> I am really not sure what does -1 imply in the final score. But when it's available, sorting is not done correctly.
image

Issue:3-> Also sorting by Provisional score for the below past-challenge seems to have an issue:
image

@codeMinter
Copy link
Contributor Author

codeMinter commented Nov 20, 2019

@nithyaasworld

  1. What is sorting column? Is it Provisional rank ?

  2. It should not show -1, as per my knowledge, we decided to show the icon with cross and not -1. But since this is existing issue, we should open a new ticket for it I think to address this.

  3. This is weird issue, as it works fine on Safari. Checking for chrome, why not working.

@nithyaasworld
Copy link
Collaborator

Ok, For:1 -> It is when sorted by default. That is, it happens when I access the URL directly

@codeMinter
Copy link
Contributor Author

yes 1 is Provisional score by default, if Review of challenge hasn't completed. we can swap to do it as Provisional Rank by default.

@codeMinter
Copy link
Contributor Author

codeMinter commented Nov 20, 2019

@nithyaasworld to fix the above add-on issues, following has been done:

  1. Default sorting has been moved to Provisional Rank (when Review not complete) and Final Rank (when review complete)

  2. All -1 final scores have been fixed to be 0, as min final score can be 0.

  3. Sorting issues fixed.

@nithyaasworld
Copy link
Collaborator

Thanks @codeMinter This is verified.

@nithyaasworld
Copy link
Collaborator

Verified in Production.

Note: "country name/flag" is out of scope for now. A new ticket has to be logged if we need them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants